Re: pgsql: Fix an oversight in join-removal optimization: we have to check

Lists: pgsql-committers
From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix an oversight in join-removal optimization: we have to check
Date: 2010-03-22 13:57:16
Message-ID: 20100322135716.4A93E7541D0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
-----------
Fix an oversight in join-removal optimization: we have to check not only for
plain Vars that are generated in the inner rel and used above the join, but
also for PlaceHolderVars. Per report from Oleg K.

Modified Files:
--------------
pgsql/src/backend/optimizer/path:
joinpath.c (r1.130 -> r1.131)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/joinpath.c?r1=1.130&r2=1.131)
pgsql/src/test/regress/expected:
join.out (r1.43 -> r1.44)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.43&r2=1.44)
pgsql/src/test/regress/sql:
join.sql (r1.32 -> r1.33)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.32&r2=1.33)

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an oversight in join-removal optimization: we have to check
Date: 2010-03-22 16:27:28
Message-ID: 20100322162728.GD26428@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Mon, Mar 22, 2010 at 01:57:16PM +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix an oversight in join-removal optimization: we have to check not only for
> plain Vars that are generated in the inner rel and used above the join, but
> also for PlaceHolderVars. Per report from Oleg K.

That's short for Oleg Kolyhalin. Can we get this into the release
notes?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an oversight in join-removal optimization: we have to check
Date: 2010-03-22 16:38:00
Message-ID: 22263.1269275880@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

David Fetter <david(at)fetter(dot)org> writes:
> On Mon, Mar 22, 2010 at 01:57:16PM +0000, Tom Lane wrote:
>> Log Message:
>> -----------
>> Fix an oversight in join-removal optimization: we have to check not only for
>> plain Vars that are generated in the inner rel and used above the join, but
>> also for PlaceHolderVars. Per report from Oleg K.

> That's short for Oleg Kolyhalin. Can we get this into the release
> notes?

We do not normally bother to record alpha bugs in the release notes.

regards, tom lane