Re: [COMMITTERS] pgsql: Also update ChangerLog file.

Log Message:
-----------
Also update ChangerLog file.

Modified Files:
--------------
pgsql/src/interfaces/ecpg:
ChangeLog (r1.403 -> r1.404)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ChangeLog?r1=1.403&r2=1.404)

Michael Meskes wrote:
> Log Message:
> -----------
> Also update ChangerLog file.

Hmm not sure I find that commit message really helpful - but is it
actually of any use to maintain a Changelog file specifically for ECPG?

Stefan

On Fri, Jan 08, 2010 at 09:06:05AM +0000, Michael Meskes wrote:
> Log Message:
> -----------
> Also update ChangerLog file.

This is *seriously* unhelpful. What in this file did you change, and
what possessed you not to describe it in even the most general terms?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote:
> This is *seriously* unhelpful. What in this file did you change, and
> what possessed you not to describe it in even the most general terms?

What do you expect me to write when I just added a one line to the changelog
saying that I applied Zoltan's patch? Yes, this should have been in the last
commit but wasn't, but do you really expect me to add all the info into the
commit yet again?

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL

On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote:
> Hmm not sure I find that commit message really helpful - but is it
> actually of any use to maintain a Changelog file specifically for
> ECPG?

Makes it easier to see what's new in ecpg when doing a new release. But I guess
we could get all this from the cvs log too. The file has been there for a long time.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL

Michael Meskes <meskes(at)postgresql(dot)org> writes:
> On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote:
>> Hmm not sure I find that commit message really helpful - but is it
>> actually of any use to maintain a Changelog file specifically for
>> ECPG?

> Makes it easier to see what's new in ecpg when doing a new
> release. But I guess we could get all this from the cvs log too. The
> file has been there for a long time.

Well, I'm pretty sure that release notes are prepared off of the cvs log
entries. I've never looked at ecpg's Changelog when working on notes,
and I'd be prepared to bet that Bruce hasn't either. My advice is to
drop the Changelog file and be sure you describe changes appropriately
in the commit messages.

regards, tom lane

On Sat, Jan 9, 2010 at 17:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Meskes <meskes(at)postgresql(dot)org> writes:
>> On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote:
>>> Hmm not sure I find that commit message really helpful - but is it
>>> actually of any use to maintain a Changelog file specifically for
>>> ECPG?
>
>> Makes it easier to see what's new in ecpg when doing a new
>> release. But I guess we could get all this from the cvs log too. The
>> file has been there for a long time.
>
> Well, I'm pretty sure that release notes are prepared off of the cvs log
> entries.  I've never looked at ecpg's Changelog when working on notes,
> and I'd be prepared to bet that Bruce hasn't either.  My advice is to
> drop the Changelog file and be sure you describe changes appropriately
> in the commit messages.

+1.
Seems really weird (and unnecessary) to have a changelog for just one
small "subsystem", when we don't have it for the others.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

On Sat, Jan 09, 2010 at 11:55:00AM -0500, Tom Lane wrote:
> Well, I'm pretty sure that release notes are prepared off of the cvs log
> entries. I've never looked at ecpg's Changelog when working on notes,
> and I'd be prepared to bet that Bruce hasn't either. My advice is to
> drop the Changelog file and be sure you describe changes appropriately
> in the commit messages.

You definitely get a +1 from me as this file only means additional work that
tends to be forgotten. And yes, it does not have any information that the CVS
log doesn't have.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL

On Fri, Jan 8, 2010 at 4:57 PM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote:
>> This is *seriously* unhelpful.  What in this file did you change, and
>> what possessed you not to describe it in even the most general terms?
>
> What do you expect me to write when I just added a one line to the changelog
> saying that I applied Zoltan's patch? Yes, this should have been in the last
> commit but wasn't, but do you really expect me to add all the info into the
> commit yet again?

How about "Update ChangeLog for Zoltan's recent ECPG cleanup pach", or somesuch?

...Robert

On Sat, Jan 09, 2010 at 01:06:47PM -0500, Robert Haas wrote:
> On Fri, Jan 8, 2010 at 4:57 PM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> > On Fri, Jan 08, 2010 at 10:08:38AM -0800, David Fetter wrote:
> >> This is *seriously* unhelpful.  What in this file did you change,
> >> and what possessed you not to describe it in even the most
> >> general terms?
> >
> > What do you expect me to write when I just added a one line to the
> > changelog saying that I applied Zoltan's patch? Yes, this should
> > have been in the last commit but wasn't, but do you really expect
> > me to add all the info into the commit yet again?
>
> How about "Update ChangeLog for Zoltan's recent ECPG cleanup pach",
> or somesuch?

I've phrased this as:

- In pgsql/src/interfaces/ecpg/ChangeLog, add Zoltan Boszormenyi's
recent ECPG cleanup patch.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Tom Lane wrote:
> Michael Meskes <meskes(at)postgresql(dot)org> writes:
> > On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote:
> >> Hmm not sure I find that commit message really helpful - but is it
> >> actually of any use to maintain a Changelog file specifically for
> >> ECPG?
>
> > Makes it easier to see what's new in ecpg when doing a new
> > release. But I guess we could get all this from the cvs log too. The
> > file has been there for a long time.
>
> Well, I'm pretty sure that release notes are prepared off of the cvs log
> entries. I've never looked at ecpg's Changelog when working on notes,
> and I'd be prepared to bet that Bruce hasn't either. My advice is to
> drop the Changelog file and be sure you describe changes appropriately
> in the commit messages.

Agreed. I was never aware of an ecpg changelog file. Let's remove it
and Michael can make any clarifications to the major releases he wants.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +