Lists: | pgsql-rrreviewers |
---|
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | reviews not completed |
Date: | 2009-09-21 02:58:57 |
Message-ID: | 603c8f070909201958i301a70d7i77fcc5ad57027c72@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
Here's my list of who seems not to have reviewed the patch they were
assigned. Have I falsely maligned anyone? Please let me know if you
are no longer able to review, or when you expect your review to be
posted. Thanks. ...Robert
Andres Freund <andres(at)anarazel(dot)de>
- GRANT ON ALL IN schema
Stephen Frost <sfrost(at)snowman(dot)net>
- Reworks for Access Controls
Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
- Largeobject access controls
Jan Urbański <wulczer(at)wulczer(dot)org>
- Default ACLs
...but this WAS reviewed by Josh Tolley (perhaps in error?)
Joshua Tolley <eggyknap(at)gmail(dot)com>
- DML node in support of writeable CTEs
Josh Williams <joshwilliams(at)ij(dot)net> WINDOWS
- Encoding issues in console and eventlog on win32
From: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 06:44:36 |
Message-ID: | 3073cc9b0909202344s6cb3f04cl420c4c35e8756464@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
On Sun, Sep 20, 2009 at 9:58 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Here's my list of who seems not to have reviewed the patch they were
> assigned. Have I falsely maligned anyone? Please let me know if you
> are no longer able to review, or when you expect your review to be
> posted. Thanks. ...Robert
>
[...]
>
> Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
> - Largeobject access controls
>
Sorry, i had a horrible week...
i have just sent a review, do you think we have to wait a few days to
see if there is any response to it or just assign me a new patch just
now
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157
From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 08:25:44 |
Message-ID: | 4AB73888.4010502@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
Robert Haas wrote:
> Jan Urbański <wulczer(at)wulczer(dot)org>
> - Default ACLs
> ...but this WAS reviewed by Josh Tolley (perhaps in error?)
Was it? The commitfest page only has a link to the updated version that
includes a file that was missing from the patch.
I was supposed to send the review on Saturday and failed miserably. I
will hovewer send it today.
Cheers,
Jan
From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-rrreviewers(at)postgresql(dot)org |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 08:45:20 |
Message-ID: | 200909211045.21783.andres@anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
Hi,
On Monday 21 September 2009 04:58:57 Robert Haas wrote:
> Here's my list of who seems not to have reviewed the patch they were
> assigned. Have I falsely maligned anyone? Please let me know if you
> are no longer able to review, or when you expect your review to be
> posted. Thanks. ...Robert
>
> Andres Freund <andres(at)anarazel(dot)de>
> - GRANT ON ALL IN schema
I was on the road more than I planned - will take a stab in the next two days.
Andres
From: | Petr Jelinek <pjmodos(at)pjmodos(dot)net> |
---|---|
To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 10:52:08 |
Message-ID: | 4AB75AD8.30804@pjmodos.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
Jan Urbański napsal(a):
> Robert Haas wrote:
>
>> Jan Urbański <wulczer(at)wulczer(dot)org>
>> - Default ACLs
>> ...but this WAS reviewed by Josh Tolley (perhaps in error?)
>>
>
> Was it? The commitfest page only has a link to the updated version that
> includes a file that was missing from the patch.
>
> I was supposed to send the review on Saturday and failed miserably. I
> will hovewer send it today.
>
It wasn't, the patch is completely different in this commitfest.
--
Regards
Petr Jelinek (PJMODOS)
From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 14:21:09 |
Message-ID: | 20090921142109.GD17756@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net>
> - Reworks for Access Controls
I'm planning to finish my review of this by the end of the week.
Thanks,
Stephen
From: | Joshua Tolley <eggyknap(at)gmail(dot)com> |
---|---|
To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 15:33:01 |
Message-ID: | 20090921153301.GJ5554@eddie |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
On Mon, Sep 21, 2009 at 10:25:44AM +0200, Jan Urbański wrote:
> Robert Haas wrote:
> > Jan Urbański <wulczer(at)wulczer(dot)org>
> > - Default ACLs
> > ...but this WAS reviewed by Josh Tolley (perhaps in error?)
>
> Was it? The commitfest page only has a link to the updated version that
> includes a file that was missing from the patch.
>
> I was supposed to send the review on Saturday and failed miserably. I
> will hovewer send it today.
I did it last commitfest. Haven't touched it for this one, though.
--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Joshua Tolley <eggyknap(at)gmail(dot)com> |
Cc: | Jan Urbański <wulczer(at)wulczer(dot)org>, pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-21 15:34:32 |
Message-ID: | 603c8f070909210834g39fc3749n989bb24525a8ebf2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
On Mon, Sep 21, 2009 at 11:33 AM, Joshua Tolley <eggyknap(at)gmail(dot)com> wrote:
> On Mon, Sep 21, 2009 at 10:25:44AM +0200, Jan Urbański wrote:
>> Robert Haas wrote:
>> > Jan Urbański <wulczer(at)wulczer(dot)org>
>> > - Default ACLs
>> > ...but this WAS reviewed by Josh Tolley (perhaps in error?)
>>
>> Was it? The commitfest page only has a link to the updated version that
>> includes a file that was missing from the patch.
>>
>> I was supposed to send the review on Saturday and failed miserably. I
>> will hovewer send it today.
>
> I did it last commitfest. Haven't touched it for this one, though.
Sorry, my error.
...Robert
From: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: reviews not completed |
Date: | 2009-09-22 22:23:17 |
Message-ID: | 3073cc9b0909221523y7f84b209p6209f38c8c37f66@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-rrreviewers |
On Mon, Sep 21, 2009 at 1:44 AM, Jaime Casanova
<jcasanov(at)systemguards(dot)com(dot)ec> wrote:
>
> do you think we have to wait a few days to
> see if there is any response to it or just assign me a new patch just
> now
>
ok. there was some discussion about this one and now seems like Kaigai
will do some minor adjustments and an addition to the patch...
anyone objects if i take the "lock wait statistics" patch? i will send
a review for saturday or sunday, if anyone can beat me then fine...
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157