Re: [COMMITTERS] pgsql: CVS NULL Documentation Clearify documentation of CVS's output of

Lists: pgsql-committerspgsql-hackers
From: momjian(at)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: CVS NULL Documentation Clearify documentation of CVS's output of
Date: 2009-09-17 21:13:02
Message-ID: 20090917211302.05DB2753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
CVS NULL Documentation

Clearify documentation of CVS's output of NULL values, per suggestion
from Magnus.

Backpatch to 8.4.X.

Modified Files:
--------------
pgsql/doc/src/sgml/ref:
copy.sgml (r1.87 -> r1.88)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/copy.sgml?r1=1.87&r2=1.88)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: CVS NULL Documentation Clearify documentation of CVS's output of
Date: 2009-09-17 21:22:17
Message-ID: 4225.1253222537@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Log Message:
> -----------
> CVS NULL Documentation

> Clearify documentation of CVS's output of NULL values, per suggestion
> from Magnus.

This has not "clarified" anything; what it has done is transformed
correct statements into incorrect ones. You forgot about the
possibility that the copy is using a nonempty string as the "null
string". Kindly revert.

regards, tom lane

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: CVS NULL Documentation Clearify documentation of CVS's output of
Date: 2009-09-17 21:28:16
Message-ID: 603c8f070909171428i57ee2be8id4ffde0a6587b4f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Thu, Sep 17, 2009 at 5:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
>> Log Message:
>> -----------
>> CVS NULL Documentation
>
>> Clearify documentation of CVS's output of NULL values, per suggestion
>> from Magnus.
>
> This has not "clarified" anything; what it has done is transformed
> correct statements into incorrect ones.  You forgot about the
> possibility that the copy is using a nonempty string as the "null
> string".  Kindly revert.

Also, the format is called CSV, not CVS.

...Robert

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: CVS NULL Documentation Clearify documentation of CVS's output of
Date: 2009-09-17 22:13:33
Message-ID: 200909172213.n8HMDXO11637@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > CVS NULL Documentation
>
> > Clearify documentation of CVS's output of NULL values, per suggestion
> > from Magnus.
>
> This has not "clarified" anything; what it has done is transformed
> correct statements into incorrect ones. You forgot about the
> possibility that the copy is using a nonempty string as the "null
> string". Kindly revert.

It has been adjusted per Andrew's suggestion.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +