Re: New pg_dump patch -- document statistics collector exception

This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.

It is an alternative to the prior patch, which supplied a --no-stats flag.

This is a documentation only patch, not tied to a recent code change.

On Tuesday 20 January 2009 20:22:10 Bryce Nesbitt wrote:
> This is a proposed patch to document disabling the statistics collector
> pg_dump activity, and give a bit more visibility to the PGOPTIONS
> environment variable supported by libpq.
>
> It is an alternative to the prior patch, which supplied a --no-stats flag.
>
> This is a documentation only patch, not tied to a recent code change.

s/varriable/variable/g

also, I forget which way is proper, but you're inconsistent with your closing
tags for <application> in that paragraph (using both </application and </>)

--
Robert Treat
Conjecture: http://www.xzilla.net
Consulting: http://www.omniti.com

Robert Treat wrote:

> also, I forget which way is proper, but you're inconsistent with your closing
> tags for <application> in that paragraph (using both </application and </>)

They're both acceptable.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?
-Bryce

Bryce Nesbitt wrote:
> Here's a revision (thanks Robert Treat for the spelling corrextion).
> If there are no other objections, how do I nominate it for consideration?
> -Bryce

You already have.

Mind you, in the future when you're not continuing a discussion from a
code patch, you should submit doc patches to pgsql-docs. But I'm sure
Peter has seen it here.

--Josh

Bryce Nesbitt escreveu:
> Here's a revision (thanks Robert Treat for the spelling corrextion).
> If there are no other objections, how do I nominate it for consideration?
>
Added to next commit fest [1].

[1] http://wiki.postgresql.org/wiki/CommitFest_2009-First

--
Euler Taveira de Oliveira
http://www.timbira.com/

Euler Taveira de Oliveira wrote:
> Bryce Nesbitt escreveu:
>> Here's a revision (thanks Robert Treat for the spelling corrextion).
>> If there are no other objections, how do I nominate it for consideration?
>>
> Added to next commit fest [1].

Um, not necessary. We're still accepting new doc patches, and will
until the end of beta.

--Josh

Bryce Nesbitt wrote:
> This is a proposed patch to document disabling the statistics collector
> pg_dump activity, and give a bit more visibility to the PGOPTIONS
> environment variable supported by libpq.
>
> It is an alternative to the prior patch, which supplied a --no-stats flag.
>
> This is a documentation only patch, not tied to a recent code change.

Patch applied, with spelling correction already noted.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Josh Berkus wrote:
> Euler Taveira de Oliveira wrote:
> > Bryce Nesbitt escreveu:
> >> Here's a revision (thanks Robert Treat for the spelling corrextion).
> >> If there are no other objections, how do I nominate it for consideration?
> >>
> > Added to next commit fest [1].
>
> Um, not necessary. We're still accepting new doc patches, and will
> until the end of beta.

Yep, patch commited, removed from next commit fest.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Apologies. Turns out the name of the relevant setting was changed for 8.3! So a revised patch is attached.

For backing, see:

http://www.postgresql.org/docs/8.3/static/release-8-3.html

" Numerous changes in administrative server parameters...

stats_block_level and stats_row_level are merged into track_counts."

Bruce Momjian wrote:

Bryce Nesbitt wrote:


This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.

It is an alternative to the prior patch, which supplied a --no-stats flag.

This is a documentation only patch, not tied to a recent code change.


Patch applied, with spelling correction already noted.

> Apologies. Turns out the name of the relevant setting was changed
> for 8.3! So a revised patch is attached.
> For backing, see:
> http://www.postgresql.org/docs/8.3/static/release-8-3.html
> " Numerous changes in administrative server parameters...
> stats_block_level and stats_row_level are merged into track_counts."
> Bryce Nesbitt wrote:

We don't want a pg_dump flag; the doc mention is good enough.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:

Apologies. Turns out the name of the relevant setting was changed
for 8.3! So a revised patch is attached.
For backing, see:
http://www.postgresql.org/docs/8.3/static/release-8-3.html
" Numerous changes in administrative server parameters...
stats_block_level and stats_row_level are merged into track_counts."
Bryce Nesbitt wrote:


We don't want a pg_dump flag; the doc mention is good enough.

Doh! Try this one instead. Postgres 8.3 changed the name of the flag mentioned in the doc.

> We don't want a pg_dump flag; the doc mention is good enough.
>
>
> Doh! Try this one instead. Postgres 8.3 changed the name of the
> flag mentioned in the doc.

[ Please avoid html-only email.]

OK, patch applied, but I removed the mention of pre-8.3 because this is
going only in the 8.4 docs.

Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +