Re: Segfault on CVS HEAD

Lists: pgsql-hackers
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Segfault on CVS HEAD
Date: 2009-01-05 21:59:05
Message-ID: 200901052159.n05Lx5B01291@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I am seeing the following segmentation fault when doing 'gmake install'
on CVS HEAD; any idea why?

$ gmake install
/bin/sh ../config/mkinstalldirs '/usr/local/pgsql/lib/pgxs/src'
/bin/sh ../config/install-sh -c -m 644 Makefile.global '/usr/local/pgsql/lib/pgxs/src/Makefile.global'
/bin/sh ../config/install-sh -c -m 644 Makefile.port '/usr/local/pgsql/lib/pgxs/src/Makefile.port'
/bin/sh ../config/install-sh -c -m 644 ./Makefile.shlib '/usr/local/pgsql/lib/pgxs/src/Makefile.shlib'
/bin/sh ../config/install-sh -c -m 644 ./nls-global.mk '/usr/local/pgsql/lib/pgxs/src/nls-global.mk'
gmake -C port install
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
/bin/sh ../../config/install-sh -c -m 644 libpgport.a '/usr/local/pgsql/lib/libpgport.a'
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake -C timezone install
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/timezone'
gmake -C ../../src/port all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake: *** [install] Segmentation fault
$

I rebooted my server but it didn't help. All this just started today.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Segfault on CVS HEAD
Date: 2009-01-05 23:41:22
Message-ID: 20090105234122.GI7345@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian wrote:

> gmake: *** [install] Segmentation fault
> $
>
> I rebooted my server but it didn't help. All this just started today.

Your make is buggy?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Segfault on CVS HEAD
Date: 2009-01-06 00:16:47
Message-ID: 28667.1231201007@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Bruce Momjian wrote:
>> gmake: *** [install] Segmentation fault

> Your make is buggy?

I'm not totally sure, but I think this is make reporting that install
crashed. Perhaps a corrupted install executable?

regards, tom lane


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Segfault on CVS HEAD
Date: 2009-01-06 02:26:09
Message-ID: 200901060226.n062Q9I10451@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Bruce Momjian wrote:
> >> gmake: *** [install] Segmentation fault
>
> > Your make is buggy?
>
> I'm not totally sure, but I think this is make reporting that install
> crashed. Perhaps a corrupted install executable?

Turns out the cause was a buggy gmake that segment fauled on this:

$(if $(ZIC),$(ZIC),./zic) -d ...

It affects at least gmake 3.78.1 but is fixed in at least version 3.81.
I talked to Peter and it seemed easist to just simplify the gmake rules
and document the issue with a comment, attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 1.2 KB