BUG #4186: set lc_messages does not work

The following bug has been logged online:

Bug reference: 4186
Logged by: Thomas H
Email address: me(at)alternize(dot)com
PostgreSQL version: 8.3.1
Operating system: Windows 2003
Description: set lc_messages does not work
Details:

the patch discussed here [1] that supposedly made the win32 msvc builds use
lc_locale properly has flaws.

while indeed it does force pgsql to use the native win32 locale for error
messages (before 8.3.1, system messages were always english), it broke the
functionality to actually have the lc_messages locale set manually through
conf or in a user session.

the following output is from a win2003 system with German_Switzerland.1252
locale. the queries are identically to the one used as examples by the patch
author.
i have added a "select x;" to trigger a system error message to show that
its actually misbehaving - all output is always in (swiss) german despite
the set locale.

- thomas

[1]
http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php

--------------------------------

Dies ist psql 8.3.1, das interaktive PostgreSQL-Terminal.

Geben Sie ein: \copyright fr Urheberrechtsinformationen
\h fr Hilfe ber SQL-Anweisungen
\? fr Hilfe ber interne Anweisungen
\g oder Semikolon, um eine Anfrage auszufhren
\q um zu beenden

Warnung: Konsolencodeseite (850) unterscheidet sich von der Windows-
Codeseite (1252). 8-Bit-Zeichen funktionieren mglicherweise
nicht
richtig. Einzelheiten finden Sie auf der psql-Handbuchseite unter
Notes for Windows users.

endor=# set lc_messages to 'sv_SE';
SET
endor=# select to_char((current_date + s.a),'TMDay TMMonth YYYY') as dates
from
generate_series(0,6) as s(a);
dates
---------------------
Donnerstag Mai 2008
Freitag Mai 2008
Samstag Mai 2008
Sonntag Mai 2008
Montag Mai 2008
Dienstag Mai 2008
Mittwoch Mai 2008
(7 Zeilen)

endor=# select x;
FEHLER: Spalte x existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'de_DE';
SET
endor=# select to_char((current_date + s.a),'TMDay TMMonth YYYY') as dates
from
generate_series(0,6) as s(a);
dates
---------------------
Donnerstag Mai 2008
Freitag Mai 2008
Samstag Mai 2008
Sonntag Mai 2008
Montag Mai 2008
Dienstag Mai 2008
Mittwoch Mai 2008
(7 Zeilen)

endor=# select x;
FEHLER: Spalte x existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'English_United_States';
SET
endor=# select to_char((current_date + s.a),'TMDay TMMonth YYYY') as dates
from
generate_series(0,6) as s(a);
dates
---------------------
Donnerstag Mai 2008
Freitag Mai 2008
Samstag Mai 2008
Sonntag Mai 2008
Montag Mai 2008
Dienstag Mai 2008
Mittwoch Mai 2008
(7 Zeilen)

endor=# select x;
FEHLER: Spalte x existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'fr';
SET
endor=# select to_char((current_date + s.a),'TMDay TMMonth YYYY') as dates
from
generate_series(0,6) as s(a);
dates
---------------------
Donnerstag Mai 2008
Freitag Mai 2008
Samstag Mai 2008
Sonntag Mai 2008
Montag Mai 2008
Dienstag Mai 2008
Mittwoch Mai 2008
(7 Zeilen)

endor=# select x;
FEHLER: Spalte x existiert nicht
ZEILE 1: select x;

Thomas H wrote:

> the patch discussed here [1] that supposedly made the win32 msvc builds use
> lc_locale properly has flaws.
>
I think you misunderstood the feature [1] added recently. This new
feature doesn't rely on lc_messages to localize the day and month names;
it uses lc_time. Look at the archives for reference.

[1] http://archives.postgresql.org/pgsql-patches/2008-04/msg00451.php

--
Euler Taveira de Oliveira
http://www.timbira.com/

euler taveira de olivieira wrote:

>> the patch discussed here [1] that supposedly made the win32 msvc
>> builds use
>> lc_locale properly has flaws.
>>
> I think you misunderstood the feature [1] added recently. This new

actually no. the problem is as i intended to point out with the system
generated error messages. their language is supposedly controlled by
LC_MESSAGES (as was the time/date output, according to the first
february patch submission).

please observe the (previously already submitted) test queries. i've
removed the date/time testqueries to no further distract from the
problem. the bogus query "select x;" always results in a german error
messages no matter what LC_MESSAGES is set:

endor=# set lc_messages to 'sv_SE';
SET
endor=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'de_DE';
SET
endor=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'English_United_States';
SET
endor=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
endor=#
endor=# set lc_messages to 'fr';
SET
endor=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;

setting LC_MESSAGES in postgres.conf doesn't change anything either. and
the comment there says explicitly that LC_MESSAGES is used for system
errors:

lc_messages = 'English_United_States' # locale for system error message
# strings

nevertheless, everything is outputted in german now, errors as well as
logs. which seems to hint at 8.3.1 ignoring the LC_MESSAGES and always
using the os' locale.

regards,
thomas

Thomas H. wrote:

> please observe the (previously already submitted) test queries. i've
> removed the date/time testqueries to no further distract from the
> problem. the bogus query "select x;" always results in a german error
> messages no matter what LC_MESSAGES is set:
>
OK, that's another problem. AFAIK, that's a known problem because
Windows doesn't have LC_MESSAGES. The above comment (pg_locale.c)
suggests that there is no verification for the locale that is been set.
A possible solution is to use IsValidLocaleName() [1] or
LocaleNameToLCID() [2] but it seems that they're only available for
Vista. :( Maybe we could emulate one of these functions with a mapping
table [3]. [searching ...] It seems there are problems with LCIDs; they
don't describe the locales acurately. pgwin hackers?
Could you try to use one of the locale names described in [4]?

/*
* LC_MESSAGES category does not exist everywhere, but accept it anyway
*
* On Windows, we can't even check the value, so the non-doit case is a
* no-op
*/

[1] http://msdn.microsoft.com/en-us/library/ms776379(VS.85).aspx
[2] http://msdn.microsoft.com/en-us/library/ms776388(VS.85).aspx
[3] http://msdn.microsoft.com/en-us/library/ms776260.aspx

--
Euler Taveira de Oliveira
http://www.timbira.com/

Euler Taveira de Oliveira wrote:

>> please observe the (previously already submitted) test queries. i've
>> removed the date/time testqueries to no further distract from the
>> problem. the bogus query "select x;" always results in a german error
>> messages no matter what LC_MESSAGES is set:
>>
> OK, that's another problem. AFAIK, that's a known problem because
> Windows doesn't have LC_MESSAGES. The above comment (pg_locale.c)
> suggests that there is no verification for the locale that is been set.
> A possible solution is to use IsValidLocaleName() [1] or
> LocaleNameToLCID() [2] but it seems that they're only available for
> Vista. :( Maybe we could emulate one of these functions with a mapping
> table [3]. [searching ...] It seems there are problems with LCIDs; they
> don't describe the locales acurately. pgwin hackers?

how does LC_MESSAGES differ from for example LC_TIME? in LC_TIME, the
checking of the specified locale seems to work:

endor=# set LC_MESSAGES = 'en-US';
SET
endor=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
endor=# set LC_TIME = 'en-US';
FEHLER: ungültiger Wert für Parameter »lc_time«: »en-US«
endor=# set LC_TIME = 'en';
FEHLER: ungültiger Wert für Parameter »lc_time«: »en«
endor=# set LC_TIME = 'English';
SET

maybe one could as a workaround just use the lc_time locale checks for
lc_messages on windows systems? or at least match against the internal
pgsql supported translations. i don't mind having to specify "en"
instead of "English" if that gets me english error messages ;)

> Could you try to use one of the locale names described in [4]?

i take it you meant link [3]. i've tried 'en-US' and others, same
problem, errors in german (excerpt above).

> [1] http://msdn.microsoft.com/en-us/library/ms776379(VS.85).aspx
> [2] http://msdn.microsoft.com/en-us/library/ms776388(VS.85).aspx
> [3] http://msdn.microsoft.com/en-us/library/ms776260.aspx
>

regards,
thomas

"Thomas H" <me(at)alternize(dot)com> writes:
> Bug reference: 4186
> Logged by: Thomas H
> Email address: me(at)alternize(dot)com
> PostgreSQL version: 8.3.1
> Operating system: Windows 2003
> Description: set lc_messages does not work
> Details:

> the patch discussed here [1] that supposedly made the win32 msvc builds use
> lc_locale properly has flaws.

I think a large part of the confusion that's been evidenced in this
thread is because you are submitting a "bug report" about a patch that is
not in fact in 8.3.1 (and is unlikely ever to appear in 8.3.x at all).
It's unclear what you are really testing: stock 8.3.1? 8.3.1 plus that
patch? CVS HEAD plus the patch?

regards, tom lane

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>

>> the patch discussed here [1] that supposedly made the win32 msvc builds use
>> lc_locale properly has flaws.
>
> I think a large part of the confusion that's been evidenced in this
> thread is because you are submitting a "bug report" about a patch that is
> not in fact in 8.3.1 (and is unlikely ever to appear in 8.3.x at all).
> It's unclear what you are really testing: stock 8.3.1? 8.3.1 plus that
> patch? CVS HEAD plus the patch?

it's the 8.3.1 win32 binary coming from postgresql.org i'm using.

i was digging in the mailing list archives for some answers and found
the conversation about the patch which i believed to be included in
8.3.1. sorry for the mess :|

nevertheless the problem/bug exists: changing LC_MESSAGES has no effect
on the windows boxes, while it works on the non-win32 systems. all i
really would like is to get english system messages back on our
non-english win32 servers - like they were pre 8.3.1.

the main reason for this being: the german error messages have non-ascii
special characters in the error text ('»' and '«') which mess with some
of our applications (whereas english messages use '"').

regards,
thomas

"Thomas H." <me(at)alternize(dot)com> writes:
> nevertheless the problem/bug exists: changing LC_MESSAGES has no effect
> on the windows boxes, while it works on the non-win32 systems. all i
> really would like is to get english system messages back on our
> non-english win32 servers - like they were pre 8.3.1.

So far as I can tell, the backend's handling of LC_MESSAGES hasn't
changed at all between 8.1.2 and 8.3.1, so if it used to work for you
then there's been some other relevant change. Any idea what?

regards, tom lane

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> "Thomas H." <me(at)alternize(dot)com> writes:
>> nevertheless the problem/bug exists: changing LC_MESSAGES has no effect
>> on the windows boxes, while it works on the non-win32 systems. all i
>> really would like is to get english system messages back on our
>> non-english win32 servers - like they were pre 8.3.1.
>
> So far as I can tell, the backend's handling of LC_MESSAGES hasn't
> changed at all between 8.1.2 and 8.3.1, so if it used to work for you
> then there's been some other relevant change. Any idea what?

well... i'm not saying it worked in earlier versions. but prior to 8.3.1
(i've tested 8.3.0 and 8.2.3), the error messages were in english no
matter what the config file or the os locale says.

now, with 8.3.1, error & system messages are always in the os' locale,
and thus the bugreport. there is currently no way to set the pg system
messages' language, as the LC_MESSAGES setting seems to be defunct on
win32 systems.

as a small "proof", i installed the win32 8.3.0 from postgresql.org as a
fresh install and changed the postgresl.conf' lc_messages value to
'English_UnitedStates'. here's the psql output:

8.3.0:
-----------------------------------
postgres=# show lc_messages;
lc_messages
--------------------
English_UnitedStates
(1 row)

postgres=# select x;
ERROR: column "x" does not exist
LINE 1: select x;
^
postgres=# set lc_messages='French';
SET
postgres=# select x;
ERROR: column "x" does not exist
LINE 1: select x;
^
postgres=#
-----------------------------------

--> all system messages are in english.

after *upgrading* to 8.3.1 (again, using the official binaries), the
output looks like this:

8.3.1:
-----------------------------------
postgres=# show lc_messages;
lc_messages
----------------------
English_UnitedStates
(1 Zeile)

postgres=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
postgres=# set lc_messages='French';
SET
postgres=# select x;
FEHLER: Spalte »x« existiert nicht
ZEILE 1: select x;
^
postgres=# show lc_messages;
lc_messages
-------------
French
(1 Zeile)

postgres=#

-----------------------------------

--> all system messages are in german (the os' locale)

so clearly between 8.3.0 and 8.3.1, something must have changed. but the
only patch that concerned win32 msvc/locale is the one you said wasn't
even included...

what i noticed: if i delete the folder share/locale/de/ the system
messages are back to english - but that can't be THE solution, can it? :)

regards,
thomas

From: Thomas H. <me(at)alternize(dot)com>
> what i noticed: if i delete the folder share/locale/de/ the system
> messages are back to english - but that can't be THE solution, can it? :)

well, it actually was the solution, at least to the weird part of the
problem:

there are two versions of win32 binaries available on postgres.org.
there's the installer msi version, and there is the installerless zip
version.

the installer version does NOT install the folder "share/locale/"! so
when using the msi installer, postgres has no translations at all - thus
the fallback to english.

the zipped version contains the "share/locale/" folder. for installing
8.3.0, i've been using the msi installer version. for upgrading to
8.3.1, i've been unpacking the files from zip version into the
postgresql directory...

i've just verified that the 8.3.1 msi version provided on postgres.org
also does NOT contain the "locale" folder & files. should i report this
as a separate bug/problem?

so at least that explains the "changed" behaviour. nevertheless,
LC_MESSAGES seems to be defunct - with the "locale" folder present, pg
always picks the os' language and ignores the lc_message value.

- thomas

On Thu, May 29, 2008 at 2:05 AM, Thomas H. <me(at)alternize(dot)com> wrote:
> From: Thomas H. <me(at)alternize(dot)com>
>>
> i've just verified that the 8.3.1 msi version provided on postgres.org also
> does NOT contain the "locale" folder & files. should i report this as a
> separate bug/problem?

How exactly did you do that? My installation certainly has it. If
memory serves, it's not installed by default (you have to select it in
the feature list), but it's there alright.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Thomas H. wrote:
> From: Thomas H. <me(at)alternize(dot)com>
> > what i noticed: if i delete the folder share/locale/de/ the system
> > messages are back to english - but that can't be THE solution, can
> > it? :)
>
> well, it actually was the solution, at least to the weird part of the
> problem:
>
> there are two versions of win32 binaries available on postgres.org.
> there's the installer msi version, and there is the installerless zip
> version.
>
> the installer version does NOT install the folder "share/locale/"! so
> when using the msi installer, postgres has no translations at all -
> thus the fallback to english.

Are you sure you didn't just skip enabling National Language Support?
It's not included by default, but should be available.

> so at least that explains the "changed" behaviour. nevertheless,
> LC_MESSAGES seems to be defunct - with the "locale" folder present,
> pg always picks the os' language and ignores the lc_message value.

This looks like I can reproduce though, at least on cvs head. Did this
work for you in previous versions?

//Magnus

From: Dave Page <dpage(at)pgadmin(dot)org>
> On Thu, May 29, 2008 at 2:05 AM, Thomas H. <me(at)alternize(dot)com> wrote:
>> From: Thomas H. <me(at)alternize(dot)com>
>> i've just verified that the 8.3.1 msi version provided on postgres.org also
>> does NOT contain the "locale" folder & files. should i report this as a
>> separate bug/problem?
>
> How exactly did you do that? My installation certainly has it. If
> memory serves, it's not installed by default (you have to select it in
> the feature list), but it's there alright.
>

hmm by just clicking through the standard settings. i've seen now that
the "national language support" is set to do not install by default. so
it is a feature, not a bug, sorry.

i was under the obviously wrong impression a zip-file upgrade would be
the same as an msi-upgrade.

- thomas

On Thu, May 29, 2008 at 12:23 PM, Thomas H. <me(at)alternize(dot)com> wrote:

> i was under the obviously wrong impression a zip-file upgrade would be the
> same as an msi-upgrade.

Eeep - don't do that!! That is a *very* good way to annoy the Windows
Installer and trick it into thinking things need to be repaired.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Thomas H. wrote:
>> so at least that explains the "changed" behaviour. nevertheless,
>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>> pg always picks the os' language and ignores the lc_message value.

> This looks like I can reproduce though, at least on cvs head. Did this
> work for you in previous versions?

Maybe we were using a different build of gettext in the previous
releases, one that didn't look at the same info as the current code?

Anyway the patch mentioned at the start of the thread
http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
purports to fix this. It doesn't seem to have gotten reviewed
though.

regards, tom lane

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Thomas H. wrote:
> >> so at least that explains the "changed" behaviour. nevertheless,
> >> LC_MESSAGES seems to be defunct - with the "locale" folder present,
> >> pg always picks the os' language and ignores the lc_message value.
>
> > This looks like I can reproduce though, at least on cvs head. Did this
> > work for you in previous versions?
>
> Maybe we were using a different build of gettext in the previous
> releases, one that didn't look at the same info as the current code?
>
> Anyway the patch mentioned at the start of the thread
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> purports to fix this. It doesn't seem to have gotten reviewed
> though.

Agreed. Magnus, someone, can we get feedback on the patch at this URL?

http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Tom Lane wrote:
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Thomas H. wrote:
>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>> pg always picks the os' language and ignores the lc_message value.
>>> This looks like I can reproduce though, at least on cvs head. Did this
>>> work for you in previous versions?
>> Maybe we were using a different build of gettext in the previous
>> releases, one that didn't look at the same info as the current code?
>>
>> Anyway the patch mentioned at the start of the thread
>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>> purports to fix this. It doesn't seem to have gotten reviewed
>> though.
>
> Agreed. Magnus, someone, can we get feedback on the patch at this URL?
>
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php

IIRC, there was further work to be done on the patch before it was to be
applied, and we held off the review until then.

Gevik - can you comment on this? Where are we, what needs ot be done still?

//Magnus

Hi Magnus.

I have tried with Inoue-san, investigation of this problem, and adjustment.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/pg8.3.3-to_char_gettext_format.png
Native-strftime was proposed by Tom-san. It corrects(LC_TIME) from 8.3.3.(LC_MESSAGES)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/pg_locale_patch
It has not resulted in the still final conclusion.
However, Possibly this may be the optimal one.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/wcsftimeck.c
I am creating the proposal of patch with Inoue-san.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Thomas H. wrote:
>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>> pg always picks the os' language and ignores the lc_message value.
>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>> work for you in previous versions?
>>> Maybe we were using a different build of gettext in the previous
>>> releases, one that didn't look at the same info as the current code?
>>>
>>> Anyway the patch mentioned at the start of the thread
>>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>>> purports to fix this. It doesn't seem to have gotten reviewed
>>> though.
>>
>> Agreed. Magnus, someone, can we get feedback on the patch at this URL?
>>
>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>
> IIRC, there was further work to be done on the patch before it was to be
> applied, and we held off the review until then.
>
> Gevik - can you comment on this? Where are we, what needs ot be done still?
>
> //Magnus
>
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs

My apologies on this late reply.
The way LC_MESSAGES is handled on windows is much less efficient and faulty.
While ago I started with a patch to fix some of the issues I encountered on
windows and LC_MESSAGES. But I stopped working on that patch because this
problem needed to be fixed on many other places. In Windows, handling
LC_MESSAGES will not work the same way as *nix systems, forcing us to make
ugly workarounds. (as I actually was doing with my patch)

To my opinion, unless we think of a coherent solution for handling
LC_MESSAGES/locale for both *nix and win32 platforms, fixing lc_messages and
locale issues would break more than fixing it.

BTW: The gettext library we are using on win32 is a very old one.

Regards,
Gevik.

> -----Original Message-----
> From: Magnus Hagander [mailto:magnus(at)hagander(dot)net]
> Sent: Tuesday, August 05, 2008 4:54 PM
> To: Bruce Momjian
> Cc: Tom Lane; Thomas H.; pgsql-bugs(at)postgresql(dot)org; Gevik Babakhani
> Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
>
> Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >>> Thomas H. wrote:
> >>>> so at least that explains the "changed" behaviour. nevertheless,
> >>>> LC_MESSAGES seems to be defunct - with the "locale"
> folder present,
> >>>> pg always picks the os' language and ignores the
> lc_message value.
> >>> This looks like I can reproduce though, at least on cvs head. Did
> >>> this work for you in previous versions?
> >> Maybe we were using a different build of gettext in the previous
> >> releases, one that didn't look at the same info as the
> current code?
> >>
> >> Anyway the patch mentioned at the start of the thread
> >> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> >> purports to fix this. It doesn't seem to have gotten reviewed
> >> though.
> >
> > Agreed. Magnus, someone, can we get feedback on the patch
> at this URL?
> >
> >
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>
> IIRC, there was further work to be done on the patch before
> it was to be applied, and we held off the review until then.
>
> Gevik - can you comment on this? Where are we, what needs ot
> be done still?
>
> //Magnus
>

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Thomas H. wrote:
> >> so at least that explains the "changed" behaviour. nevertheless,
> >> LC_MESSAGES seems to be defunct - with the "locale" folder present,
> >> pg always picks the os' language and ignores the lc_message value.
>
> > This looks like I can reproduce though, at least on cvs head. Did this
> > work for you in previous versions?
>
> Maybe we were using a different build of gettext in the previous
> releases, one that didn't look at the same info as the current code?
>
> Anyway the patch mentioned at the start of the thread
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> purports to fix this. It doesn't seem to have gotten reviewed
> though.

Where are we on this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Gevik Babakhani wrote:
> My apologies on this late reply.
> The way LC_MESSAGES is handled on windows is much less efficient and faulty.
> While ago I started with a patch to fix some of the issues I encountered on
> windows and LC_MESSAGES. But I stopped working on that patch because this
> problem needed to be fixed on many other places. In Windows, handling
> LC_MESSAGES will not work the same way as *nix systems, forcing us to make
> ugly workarounds. (as I actually was doing with my patch)
>
> To my opinion, unless we think of a coherent solution for handling
> LC_MESSAGES/locale for both *nix and win32 platforms, fixing lc_messages and
> locale issues would break more than fixing it.
>
> BTW: The gettext library we are using on win32 is a very old one.

This is the most recent posting on the topic, I think. Status?

---------------------------------------------------------------------------

>
> Regards,
> Gevik.
>
>
> > -----Original Message-----
> > From: Magnus Hagander [mailto:magnus(at)hagander(dot)net]
> > Sent: Tuesday, August 05, 2008 4:54 PM
> > To: Bruce Momjian
> > Cc: Tom Lane; Thomas H.; pgsql-bugs(at)postgresql(dot)org; Gevik Babakhani
> > Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
> >
> > Bruce Momjian wrote:
> > > Tom Lane wrote:
> > >> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > >>> Thomas H. wrote:
> > >>>> so at least that explains the "changed" behaviour. nevertheless,
> > >>>> LC_MESSAGES seems to be defunct - with the "locale"
> > folder present,
> > >>>> pg always picks the os' language and ignores the
> > lc_message value.
> > >>> This looks like I can reproduce though, at least on cvs head. Did
> > >>> this work for you in previous versions?
> > >> Maybe we were using a different build of gettext in the previous
> > >> releases, one that didn't look at the same info as the
> > current code?
> > >>
> > >> Anyway the patch mentioned at the start of the thread
> > >> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> > >> purports to fix this. It doesn't seem to have gotten reviewed
> > >> though.
> > >
> > > Agreed. Magnus, someone, can we get feedback on the patch
> > at this URL?
> > >
> > >
> > http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> >
> > IIRC, there was further work to be done on the patch before
> > it was to be applied, and we held off the review until then.
> >
> > Gevik - can you comment on this? Where are we, what needs ot
> > be done still?
> >
> > //Magnus
> >

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Tom Lane wrote:
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> Thomas H. wrote:
>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>> pg always picks the os' language and ignores the lc_message value.
>>> This looks like I can reproduce though, at least on cvs head. Did this
>>> work for you in previous versions?
>> Maybe we were using a different build of gettext in the previous
>> releases, one that didn't look at the same info as the current code?
>>
>> Anyway the patch mentioned at the start of the thread
>> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
>> purports to fix this. It doesn't seem to have gotten reviewed
>> though.
>
> Where are we on this?

Saito-san and I have been working on this item.
The attached patch is for MSVC version and does the following
when built under vc8 or later version MSVC.

1. Accepts Windows or ISO style locale name.
2. _putenv the ISO style locale name as LC_MESSAGES environemnt
variable so as to be referenced by the gettext library.
Note that we have to call _putenv() in msvcrt.dll not in
each MSVC version's runtime library msvcrxx.dll.
3. Calls SetThreadLocale() if necessary.
The currently used libintl3.dll(0.14.4.1592) seems to need
this handling. ISTM it is badly built and ignores the setting
of step 2.

regards,
Hiroshi Inoue

AFAIK we did not discuss this further. LC_MESSAGES and changing locale
functionality for functions like to_date on windows remains broken.

To summarize the problem:

1) On *nix systems, we use lc_messages and lc_locale both for functions
(like to to_date and to_char) and other system messages where locale plays
any role. Lc_messages and lc_locale are read from the environment variables.
Unfortunately on Windows the meaning of these variables is not the same as
on *nix systems, resulting locale assignment behave unexpectedly (broken).

2) On both systems we are using gettext library which is responsible to read
and translate to the correct locale. Gettext on *nix and Windows (and MAC)
also has different implementations for the same functionality. Not to
mention we are using a very old version of gettext on Windows.

3) As I was working on the patch to fix this I encountered places where the
usage of LC_MESSAGES and LC_LOCALE was not clear, especially for functions
where the functionality of Oracle was mimicked.

4) The entire problem came to light when we started to compile PG with MSVC
(8.3+). On 8.2 which was compiled using MinGW (I guess we do not support it
anymore) the behavior of lc_messages and lc_locale was also broken but not
as visible as with MSVC.

5) To give you an example: On *nix, the locale system acts when the value of
lc_messages or lc_locale (environment variables) changes. The expected
values are like: "en_US". On Windows on the other hand, en_US has no
meaning. It becomes something like "English (United States)", which is
ignored by gettext. Leaving us with no alternative than translating the
"English (United States)" to "en_US" and force it to gettext which does not
work all the time because gettext discards the forced value when it reloads
itself.

6) As I mentioned before, I stopped developing a patch for this because this
problem is somewhat deeper than it appears. Any attempt to fix this problem
will also result changing code for both locale aware functions like to_date
and to_char as for when to use lc_locale and lc_messages in the codebase.

Any thoughts?

Regards,
Gevik Babakhani
------------------------------------------------
PostgreSQL NL http://www.postgresql.nl
TrueSoftware BV http://www.truesoftware.nl
------------------------------------------------

> -----Original Message-----
> From: Bruce Momjian [mailto:bruce(at)momjian(dot)us]
> Sent: Sunday, December 07, 2008 4:26 AM
> To: Gevik Babakhani
> Cc: 'Magnus Hagander'; 'Tom Lane'; 'Thomas H.';
> pgsql-bugs(at)postgresql(dot)org
> Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
>
> Gevik Babakhani wrote:
> > My apologies on this late reply.
> > The way LC_MESSAGES is handled on windows is much less
> efficient and faulty.
> > While ago I started with a patch to fix some of the issues I
> > encountered on windows and LC_MESSAGES. But I stopped
> working on that
> > patch because this problem needed to be fixed on many other
> places. In
> > Windows, handling LC_MESSAGES will not work the same way as *nix
> > systems, forcing us to make ugly workarounds. (as I
> actually was doing
> > with my patch)
> >
> > To my opinion, unless we think of a coherent solution for handling
> > LC_MESSAGES/locale for both *nix and win32 platforms, fixing
> > lc_messages and locale issues would break more than fixing it.
> >
> > BTW: The gettext library we are using on win32 is a very old one.
>
> This is the most recent posting on the topic, I think. Status?
>
> --------------------------------------------------------------
> -------------
>
>
> >
> > Regards,
> > Gevik.
> >
> >
> > > -----Original Message-----
> > > From: Magnus Hagander [mailto:magnus(at)hagander(dot)net]
> > > Sent: Tuesday, August 05, 2008 4:54 PM
> > > To: Bruce Momjian
> > > Cc: Tom Lane; Thomas H.; pgsql-bugs(at)postgresql(dot)org; Gevik
> Babakhani
> > > Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
> > >
> > > Bruce Momjian wrote:
> > > > Tom Lane wrote:
> > > >> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > > >>> Thomas H. wrote:
> > > >>>> so at least that explains the "changed" behaviour.
> > > >>>> nevertheless, LC_MESSAGES seems to be defunct - with
> the "locale"
> > > folder present,
> > > >>>> pg always picks the os' language and ignores the
> > > lc_message value.
> > > >>> This looks like I can reproduce though, at least on cvs head.
> > > >>> Did this work for you in previous versions?
> > > >> Maybe we were using a different build of gettext in
> the previous
> > > >> releases, one that didn't look at the same info as the
> > > current code?
> > > >>
> > > >> Anyway the patch mentioned at the start of the thread
> > > >>
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> > > >> purports to fix this. It doesn't seem to have gotten reviewed
> > > >> though.
> > > >
> > > > Agreed. Magnus, someone, can we get feedback on the patch
> > > at this URL?
> > > >
> > > >
> > > http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
> > >
> > > IIRC, there was further work to be done on the patch
> before it was
> > > to be applied, and we held off the review until then.
> > >
> > > Gevik - can you comment on this? Where are we, what needs
> ot be done
> > > still?
> > >
> > > //Magnus
> > >
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>

Hi,

I posted a patch 18 days ago but have got no responce.
Anyway I've simplified the patch by using an appropriate
gettext module.

Hiroshi Inoue wrote:
> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Thomas H. wrote:
>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>> pg always picks the os' language and ignores the lc_message value.
>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>> work for you in previous versions?
>>> Maybe we were using a different build of gettext in the previous
>>> releases, one that didn't look at the same info as the current code?
>>>
>>
>> Where are we on this?

AFAICS there are 2 causes.

1. MSVC version of postgres is using a bad gettext module.
2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.

As for 1, we have to use another gettext module. I can provide it
if requested.
As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls
corresponding putenv() whose result can be referenced by getenv() in
mingw.

In addtion the patch provides a functionality to Windows locale
name to ISO formatted locale name.

Comments ?

regards,
Hiroshi Inoue

Oops, I forgot to attach the patch, sorry.

Hiroshi Inoue wrote:
> Hi,
>
> I posted a patch 18 days ago but have got no responce.
> Anyway I've simplified the patch by using an appropriate
> gettext module.
>
> Hiroshi Inoue wrote:
>> Bruce Momjian wrote:
>>> Tom Lane wrote:
>>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>>> Thomas H. wrote:
>>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>>> pg always picks the os' language and ignores the lc_message value.
>>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>>> work for you in previous versions?
>>>> Maybe we were using a different build of gettext in the previous
>>>> releases, one that didn't look at the same info as the current code?
>>>>
>>>
>>> Where are we on this?
>
> AFAICS there are 2 causes.
>
> 1. MSVC version of postgres is using a bad gettext module.
> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>
> As for 1, we have to use another gettext module. I can provide it
> if requested.
> As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls
> corresponding putenv() whose result can be referenced by getenv() in
> mingw.
>
> In addtion the patch provides a functionality to Windows locale
> name to ISO formatted locale name.
>
> Comments ?
>
> regards,
> Hiroshi Inoue

Hi.

Sorry very late reaction....

I report the test checked again.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_01.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_02.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_03.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_04.png
and
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES.sql
Then, set PGCLIENTENCODING=SJIS
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES.log

However, libintl needs to be created correctly.(Inoue-san prepares this.)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/bin/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/include/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/lib/

in CVS-HEAD of the newest patch, line positions differ for a while.(.Inoue-san prepares this.)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/mbutils_2.patch
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/win_lc_messages_2.patch

Conclusion, looks at a good result.!!

Regards,
Hiroshi Saito

----- Original Message -----
From: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>

> Oops, I forgot to attach the patch, sorry.
>
> Hiroshi Inoue wrote:
>> Hi,
>>
>> I posted a patch 18 days ago but have got no responce.
>> Anyway I've simplified the patch by using an appropriate
>> gettext module.
>>
>> Hiroshi Inoue wrote:
>>> Bruce Momjian wrote:
>>>> Tom Lane wrote:
>>>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>>>> Thomas H. wrote:
>>>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>>>> pg always picks the os' language and ignores the lc_message value.
>>>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>>>> work for you in previous versions?
>>>>> Maybe we were using a different build of gettext in the previous
>>>>> releases, one that didn't look at the same info as the current code?
>>>>>
>>>>
>>>> Where are we on this?
>>
>> AFAICS there are 2 causes.
>>
>> 1. MSVC version of postgres is using a bad gettext module.
>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>
>> As for 1, we have to use another gettext module. I can provide it
>> if requested.
>> As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls
>> corresponding putenv() whose result can be referenced by getenv() in
>> mingw.
>>
>> In addtion the patch provides a functionality to Windows locale
>> name to ISO formatted locale name.
>>
>> Comments ?
>>
>> regards,
>> Hiroshi Inoue
>

Hiroshi Inoue wrote:
> Hiroshi Inoue wrote:
>> Hi,
>>
>> I posted a patch 18 days ago but have got no responce.
>> Anyway I've simplified the patch by using an appropriate
>> gettext module.
>>
>> Hiroshi Inoue wrote:
>>> Bruce Momjian wrote:
>>>> Tom Lane wrote:
>>>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>>>> Thomas H. wrote:
>>>>>>> so at least that explains the "changed" behaviour. nevertheless,
>>>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>>>> pg always picks the os' language and ignores the lc_message value.
>>>>>> This looks like I can reproduce though, at least on cvs head. Did
>>>>>> this
>>>>>> work for you in previous versions?
>>>>> Maybe we were using a different build of gettext in the previous
>>>>> releases, one that didn't look at the same info as the current code?
>>>>>
>>>>
>>>> Where are we on this?
>>
>> AFAICS there are 2 causes.
>>
>> 1. MSVC version of postgres is using a bad gettext module.
>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>
>> As for 1, we have to use another gettext module. I can provide it
>> if requested.

Yes, I think that'll be needed. Exactly what is wrong and needs to be
changed? (Copying DAve in on this since he builds the MSI)

Is it possible to build this one with the same version of MSVC? If it
is, then that should remove the need for #2, right?

>> As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls
>> corresponding putenv() whose result can be referenced by getenv() in
>> mingw.

Oh, yuck. This must be because msvcrt.dll (used by mingw) caches the
values in the environment.

That's a rather ugly solution, but I guess if we have no other choice..
Does it make a difference if you try to set the value using
SetEnvironmentVariable()?

It would definitely work if the gettext stuff uses
GetEnvironmentVariable(). I doubt it does though, but it might work
anyway...

>> In addtion the patch provides a functionality to Windows locale
>> name to ISO formatted locale name.
>>
>> Comments ?

I wonder if it's cleaner to use this "load msvcrt version of setenv()"
*always*. Or to cover all bases, perhaps we should always do *both* -
that is, both set in current runtime and msvcrt.dll... We don't do this
in a lot of places today, but we might use more in the future. And as
long as it's not in a performance critical path, doing it twice is
almost for free...

There is already src/port/unsetenv.c, we should probably be building on
top of that one.

As for the code itself, there are some very non-postgresql-standard
constructs in the patch, like:
+ if (result = IsoLocaleName(locale), NULL == result)
+ result = locale;

And things like:
+ return NULL;
break;

is just wrong.

And we don't normally write if (NULL == <something>).

But these are fairly simple to fix, so I can do those at commit-time.

//Magnus

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>> Hiroshi Inoue wrote:

>>>>> Where are we on this?
>>> AFAICS there are 2 causes.
>>>
>>> 1. MSVC version of postgres is using a bad gettext module.
>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>
>>> As for 1, we have to use another gettext module. I can provide it
>>> if requested.
>
> Yes, I think that'll be needed. Exactly what is wrong and needs to be
> changed? (Copying DAve in on this since he builds the MSI)

As far as I see, the libintl3.dll(version 0.14.4.1952) at
http://sourceforge.net/project/showfiles.php?group_id=23617&package_id=17255&release_id=325693
was built under a bad configuration. In fact I can see HAVE_LC_MESSAGES
#defined in src\gettext\0.14.4\gettext-0.14.4\gettext-runtime\config.h.
Probably due to this mistake, the gettext module libint3.dll doesn't see
the environment variables LC_MESSAGES etc at all and tries to call
setlocale() instead.

> Is it possible to build this one with the same version of MSVC? If it
> is, then that should remove the need for #2, right?
>
>>> As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls
>>> corresponding putenv() whose result can be referenced by getenv() in
>>> mingw.
>
> Oh, yuck. This must be because msvcrt.dll (used by mingw) caches the
> values in the environment.
>
> That's a rather ugly solution, but I guess if we have no other choice..
> Does it make a difference if you try to set the value using
> SetEnvironmentVariable()?

SetEnvironmentVariable() is called from the first in
pg_perm_setlocale().

> It would definitely work if the gettext stuff uses
> GetEnvironmentVariable().

Yes I think so.

> I doubt it does though, but it might work
> anyway...
>
>
>>> In addtion the patch provides a functionality to Windows locale
>>> name to ISO formatted locale name.
>>>
>>> Comments ?
>
> I wonder if it's cleaner to use this "load msvcrt version of setenv()"
> *always*. Or to cover all bases, perhaps we should always do *both* -
> that is, both set in current runtime and msvcrt.dll... We don't do this
> in a lot of places today, but we might use more in the future. And as
> long as it's not in a performance critical path, doing it twice is
> almost for free...

Agreed.

regards,
Hiroshi Inoue

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>>> AFAICS there are 2 causes.
>>>
>>> 1. MSVC version of postgres is using a bad gettext module.
>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>
>>> As for 1, we have to use another gettext module. I can provide it
>>> if requested.
>
> Yes, I think that'll be needed. Exactly what is wrong and needs to be
> changed? (Copying DAve in on this since he builds the MSI)
>
> Is it possible to build this one with the same version of MSVC? If it
> is, then that should remove the need for #2, right?

Maybe so but what I built was gettext-0.17 and the README.woe32 says

This file explains how to create binaries for the mingw
execution environment.....
MS Visual C/C++ with "nmake" is no longer supported.

BTW gettext-0.14.4 has both README.mingw and README.woe32. REAME.woe32
seems to be for MSVC build.

regards,
Hiroshi Inoue

Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>> Hiroshi Inoue wrote:
>>>> AFAICS there are 2 causes.
>>>>
>>>> 1. MSVC version of postgres is using a bad gettext module.
>>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>>
>>>> As for 1, we have to use another gettext module. I can provide it
>>>> if requested.
>>
>> Yes, I think that'll be needed. Exactly what is wrong and needs to be
>> changed? (Copying DAve in on this since he builds the MSI)
>>
>> Is it possible to build this one with the same version of MSVC? If it
>> is, then that should remove the need for #2, right?
>
> Maybe so but what I built was gettext-0.17 and the README.woe32 says
>
> This file explains how to create binaries for the mingw
> execution environment.....
> MS Visual C/C++ with "nmake" is no longer supported.
>
> BTW gettext-0.14.4 has both README.mingw and README.woe32. REAME.woe32
> seems to be for MSVC build.

They are so annoying...

Anyway, if they don't support it, we shuldn't try to force it. Let's go
down the path that they will have different ones, and make getenv() and
friends update both.

Do you want to send an updated patch for it, or do you want me to look
at it?

//Magus

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>> Magnus Hagander wrote:
>>> Hiroshi Inoue wrote:
>>>>> AFAICS there are 2 causes.
>>>>>
>>>>> 1. MSVC version of postgres is using a bad gettext module.
>>>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>>>
>>>>> As for 1, we have to use another gettext module. I can provide it
>>>>> if requested.
>>> Yes, I think that'll be needed. Exactly what is wrong and needs to be
>>> changed? (Copying DAve in on this since he builds the MSI)
>>>
>>> Is it possible to build this one with the same version of MSVC? If it
>>> is, then that should remove the need for #2, right?
>> Maybe so but what I built was gettext-0.17 and the README.woe32 says
>>
>> This file explains how to create binaries for the mingw
>> execution environment.....
>> MS Visual C/C++ with "nmake" is no longer supported.
>>
>> BTW gettext-0.14.4 has both README.mingw and README.woe32. REAME.woe32
>> seems to be for MSVC build.
>
> They are so annoying...
>
> Anyway, if they don't support it, we shuldn't try to force it. Let's go
> down the path that they will have different ones, and make getenv() and
> friends update both.
>
> Do you want to send an updated patch for it, or do you want me to look
> at it?

I would send a new patch to which I added a simple ISO style check for
locale names.

regards,
Hiroshi Inoue

Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>>
>> Do you want to send an updated patch for it, or do you want me to look
>> at it?
>
> I would send a new patch to which I added a simple ISO style check for
> locale names.

Attached is a new patch.
I added a simple ISO style locale name check.
Avoided codings like *NULL == somthing*.
It also includes the changes to mbutils.c and elog.c which fix
recently introduced bug by the domain name change from "postgres"
to "postgres-8.4".

regards,
Hiroshi Inoue

Hiroshi Inoue wrote:
> Hiroshi Inoue wrote:
>> Magnus Hagander wrote:
>>>
>>> Do you want to send an updated patch for it, or do you want me to look
>>> at it?
>>
>> I would send a new patch to which I added a simple ISO style check for
>> locale names.
>
> Attached is a new patch.
> I added a simple ISO style locale name check.
> Avoided codings like *NULL == somthing*.
> It also includes the changes to mbutils.c and elog.c which fix
> recently introduced bug by the domain name change from "postgres"
> to "postgres-8.4".

Attached is a further updated version of this patch. Changes include:

* Actually avoid NULL==something style coding everywhere (I think)
* Avoid coding like "if (ret = putenvFunc(envval), 0 != ret)"
* Per discussion, remove pg_locale.c specific coding, put it in
src/port, and do a redefine so we *always* use these new functions
* Some further minor cleanups
* Removed the change to mbutils.c and elog.c - those are a separate
issue, will deal with those as a separate patch.

There still needs to be some error checking added in IsoLocaleName(),
but this is a start.

Can someone please test this? :-) I can't get NLS to work at all in my
Windows install (this is nothing new, it's always been tricky) right
now. I'll work on trying to fix that, but help with testing would be
very useful meanwhile.

(It passes build on MSVC, it's just runtime i can't check)

//Magnus

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>> Hiroshi Inoue wrote:
>>> Magnus Hagander wrote:
>>>> Do you want to send an updated patch for it, or do you want me to look
>>>> at it?
>>> I would send a new patch to which I added a simple ISO style check for
>>> locale names.
>> Attached is a new patch.
>> I added a simple ISO style locale name check.
>> Avoided codings like *NULL == somthing*.
>> It also includes the changes to mbutils.c and elog.c which fix
>> recently introduced bug by the domain name change from "postgres"
>> to "postgres-8.4".
>
> Attached is a further updated version of this patch. Changes include:

Thanks.

> * Actually avoid NULL==something style coding everywhere (I think)
> * Avoid coding like "if (ret = putenvFunc(envval), 0 != ret)"
> * Per discussion, remove pg_locale.c specific coding, put it in
> src/port, and do a redefine so we *always* use these new functions
> * Some further minor cleanups
> * Removed the change to mbutils.c and elog.c - those are a separate
> issue, will deal with those as a separate patch.
>
> There still needs to be some error checking added in IsoLocaleName(),
> but this is a start.
>
> Can someone please test this? :-)

OK I would check it tonight.
Please note the patch relies on the proper gettext module.
The header, lib and dlls are placed on Saito-san's site
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/
.
Also note the current source tries to find the message catalog
postgres-8.4.mo not postgres.mo.
The attached is an example patch to change the name of mo files
at installation time. I'm not good at perl and there may be
cleaner way.

regards,
Hiroshi Inoue

Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>> There still needs to be some error checking added in IsoLocaleName(),
>> but this is a start.
>>
>> Can someone please test this? :-)
>
> OK I would check it tonight.

Thanks.

> Please note the patch relies on the proper gettext module.
> The header, lib and dlls are placed on Saito-san's site
> http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/

Aha, that I missed.

> Also note the current source tries to find the message catalog
> postgres-8.4.mo not postgres.mo.
> The attached is an example patch to change the name of mo files
> at installation time. I'm not good at perl and there may be
> cleaner way.

I've rewritten this a little bit, and will apply separately (when I have
a little more bandwidth to work with) since I assume this is needed even
without the other patch (for the non-changeable way we had before)

//Magnus

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>> Magnus Hagander wrote:
>>> There still needs to be some error checking added in IsoLocaleName(),
>>> but this is a start.
>>>
>>> Can someone please test this? :-)
>> OK I would check it tonight.
>
> Thanks.

OK seems to works here.
The attached is a test case using lc_messages C, fr, de, es and sv.

regards,
Hiroshi Inoue

Hiroshi Inoue wrote:
> Magnus Hagander wrote:
>> Hiroshi Inoue wrote:
>>> Magnus Hagander wrote:
>>>> There still needs to be some error checking added in IsoLocaleName(),
>>>> but this is a start.
>>>>
>>>> Can someone please test this? :-)
>>> OK I would check it tonight.
>>
>> Thanks.
>
> OK seems to works here.
> The attached is a test case using lc_messages C, fr, de, es and sv.

I have applied this version of the patch with some more error checking
added to the ISO locale function.

Along with the separate commit for the .mo file naming, this should
hopefully take care of this issue?

//Magnus