Re: [BUGS] psql \COPY accepts multiple NULL AS

Greetings,

psql seems to accept syntax which would be rejected by the server,
which seems a bit odd:

sfrost*=# \copy billing_data from ../BillingSamplePricerFile.csv
with csv header quote as '"' null as 'abc' null as '123'
ERROR: invalid input syntax for integer: ""

vs.

sfrost=# copy billing_data from stdin
with csv header quote as '"' null as 'abc' null as '123';
ERROR: conflicting or redundant options

Now, honestly, I'd like to see support for multiple 'NULL AS' strings,
but till that's added it'd probably be best if psql error'd on this
like the backend does rather than accepting it and then not doing it.

Thanks!

Stephen

This has been saved for the 8.4 release:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Stephen Frost wrote:
-- Start of PGP signed section.
> Greetings,
>
> psql seems to accept syntax which would be rejected by the server,
> which seems a bit odd:
>
> sfrost*=# \copy billing_data from ../BillingSamplePricerFile.csv
> with csv header quote as '"' null as 'abc' null as '123'
> ERROR: invalid input syntax for integer: ""
>
> vs.
>
> sfrost=# copy billing_data from stdin
> with csv header quote as '"' null as 'abc' null as '123';
> ERROR: conflicting or redundant options
>
> Now, honestly, I'd like to see support for multiple 'NULL AS' strings,
> but till that's added it'd probably be best if psql error'd on this
> like the backend does rather than accepting it and then not doing it.
>
> Thanks!
>
> Stephen
-- End of PGP section, PGP failed!

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Stephen Frost wrote:
-- Start of PGP signed section.
> Greetings,
>
> psql seems to accept syntax which would be rejected by the server,
> which seems a bit odd:
>
> sfrost*=# \copy billing_data from ../BillingSamplePricerFile.csv
> with csv header quote as '"' null as 'abc' null as '123'
> ERROR: invalid input syntax for integer: ""
>
> vs.
>
> sfrost=# copy billing_data from stdin
> with csv header quote as '"' null as 'abc' null as '123';
> ERROR: conflicting or redundant options
>
> Now, honestly, I'd like to see support for multiple 'NULL AS' strings,
> but till that's added it'd probably be best if psql error'd on this
> like the backend does rather than accepting it and then not doing it.

I have fixed this bug with the attached patch to CVS HEAD.

test=> \copy billing_data from ../BillingSamplePricerFile.csv with csv
header quote as '"' null as 'abc' null as '123'
\copy: parse error at "null"

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +