| Lists: | pgsql-patches |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Shlib exports file refactoring |
| Date: | 2008-02-25 21:16:02 |
| Message-ID: | 200802252216.02519.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
After seeing four nearly-identical copies of multiplatform shared library
exports file generation code, I figured this should be put in a common place.
If you like, please test the attached patch on darwin and win32, since these
platforms are mostly affected (besides linux) and I can't test them. Just
see if it builds and runs correctly. Thanks.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| Attachment | Content-Type | Size |
|---|---|---|
| exports-refactor.patch | text/x-diff | 17.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Shlib exports file refactoring |
| Date: | 2008-02-26 02:03:36 |
| Message-ID: | 20443.1203991416@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> After seeing four nearly-identical copies of multiplatform shared library
> exports file generation code, I figured this should be put in a common place.
> If you like, please test the attached patch on darwin and win32, since these
> platforms are mostly affected (besides linux) and I can't test them. Just
> see if it builds and runs correctly. Thanks.
[ shrug... ] Apply it to HEAD and see if the buildfarm complains.
We're in devel cycle now, so transient breakage isn't going to be a big
problem. If you were asking for tests that the buildfarm wouldn't make,
I might think differently ... but then you'd need to be giving some more
detailed directions than these.
regards, tom lane