BUG #3699: Fails to compile DTrace Support

The following bug has been logged online:

Bug reference: 3699
Logged by: Lee Packham
Email address: lpackham(at)gmail(dot)com
PostgreSQL version: 8.2.5
Operating system: OSX Leopard
Description: Fails to compile DTrace Support
Details:

I have built a patch to enable a working DTrace on OSX with Postgres 8.2.5.
Basically the problem is that the dtrace command on OSX doesn't have the -G
parameter - so you have to use the newer -h method to produce a header file.

I have put the patch on my blog.

http://leenux.org.uk/dtrace-patches/dtrace-with-postgres-on-osx

Hope this is of use to you guys.

Cheers,

Lee Packham

"Lee Packham" <lpackham(at)gmail(dot)com> writes:
> I have built a patch to enable a working DTrace on OSX with Postgres 8.2.5.

You can't seriously expect us to accept a patch that rips out Solaris
dtrace support to put in OSX dtrace support :-(. Can't you fix it so
that it still uses the PG_TRACEn macros?

BTW, where did you get dtrace for OSX, anyway? I don't see it on my
machines here...

regards, tom lane

From: Lee Packham <lpackham(at)gmail(dot)com>

> I have built a patch to enable a working DTrace on OSX with Postgres 8.2.5.
> Basically the problem is that the dtrace command on OSX doesn't have
> the -G
> parameter - so you have to use the newer -h method to produce a header
> file.
>

It bothers me that the Apple's Dtrace port doesn't have the -G flag. We chose the current approach for simplicity and at the same time allowing us to easily introduce a generic framework so other OSes can plug in a similar tool if needed. I have yet to review your patch in detail, but I hope it doesn't break this generic framework. More later...

-Robert

The only thing I couldn't do was sort out the makefile to auto
generate the header file. So the patch has a pre-built header file.

I don't know Make well, enough. Sorry.

But yeah - I was pretty annoyed they broke the -G parameter (i.e.
didn't include it at all.

Cheers,

Lee.

On 10/26/07, Robert Lor <Robert(dot)Lor(at)sun(dot)com> wrote:
> From: Lee Packham <lpackham(at)gmail(dot)com>
>
> > I have built a patch to enable a working DTrace on OSX with Postgres 8.2.5.
> > Basically the problem is that the dtrace command on OSX doesn't have
> > the -G
> > parameter - so you have to use the newer -h method to produce a header
> > file.
> >
>
> It bothers me that the Apple's Dtrace port doesn't have the -G flag. We chose the current approach for simplicity and at the same time allowing us to easily introduce a generic framework so other OSes can plug in a similar tool if needed. I have yet to review your patch in detail, but I hope it doesn't break this generic framework. More later...
>
> -Robert
>

"Lee Packham" <lpackham(at)gmail(dot)com> writes:
> Dtrace is in Leopard. Just so you know :)

Hmph ... that might be enough of a reason to upgrade right there ...

regards, tom lane

Tom Lane-2 wrote:
>
> "Lee Packham" <lpackham(at)gmail(dot)com> writes:
>> Dtrace is in Leopard. Just so you know :)
>
> Hmph ... that might be enough of a reason to upgrade right there ...
>
>

I believe ZFS is also in Leopard. Even more reason to upgrade!

-Robert
--
View this message in context: http://www.nabble.com/BUG--3699%3A-Fails-to-compile-DTrace-Support-tf4695658.html#a13428697
Sent from the PostgreSQL - bugs mailing list archive at Nabble.com.