| Lists: | pgsql-hackers |
|---|
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | DLLIMPORT definition |
| Date: | 2007-07-24 11:24:32 |
| Message-ID: | 20070724112432.GC19199@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
The DLLIMPORT definition used on Win32 conflicts with the headers in TCL,
at least, and possibly others.
One way to fix it is similar to the HAVE_xyz ones that I talk about in my
other email. Another way to do it would be for us to use PGDLLIMPORT
instead of DLLIMPORT. That way we'd be sure not to conflict with any
*other* third party modules as well, which could happen if you have a
server-side module that links pg to something.
We seem to have a little over 100 entries of DLLIMPORT including comments
and the ecpg regression tests that duplicate it in the output files,
so it's not a huge thing to change.
Thoughts?
//Magnus
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DLLIMPORT definition |
| Date: | 2007-07-24 21:34:10 |
| Message-ID: | 23076.1185312850@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> The DLLIMPORT definition used on Win32 conflicts with the headers in TCL,
> at least, and possibly others.
> One way to fix it is similar to the HAVE_xyz ones that I talk about in my
> other email. Another way to do it would be for us to use PGDLLIMPORT
> instead of DLLIMPORT.
PGDLLIMPORT seems the best bet to me.
regards, tom lane