Re: pgsql: Clarify some error messages about duplicate things.

Lists: pgsql-committers
From: petere(at)postgresql(dot)org (Peter Eisentraut)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clarify some error messages about duplicate things.
Date: 2007-06-03 22:16:03
Message-ID: 20070603221603.940DC9FB990@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
-----------
Clarify some error messages about duplicate things.

Modified Files:
--------------
pgsql/src/backend/access/common:
reloptions.c (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/reloptions.c.diff?r1=1.4&r2=1.5)
pgsql/src/backend/access/nbtree:
nbtinsert.c (r1.157 -> r1.158)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/nbtree/nbtinsert.c.diff?r1=1.157&r2=1.158)
pgsql/src/backend/catalog:
heap.c (r1.321 -> r1.322)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/heap.c.diff?r1=1.321&r2=1.322)
pgsql/src/backend/commands:
tablecmds.c (r1.226 -> r1.227)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c.diff?r1=1.226&r2=1.227)
pgsql/src/test/regress/expected:
alter_table.out (r1.102 -> r1.103)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out.diff?r1=1.102&r2=1.103)
arrays.out (r1.33 -> r1.34)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/arrays.out.diff?r1=1.33&r2=1.34)
create_index.out (r1.24 -> r1.25)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/create_index.out.diff?r1=1.24&r2=1.25)
inherit.out (r1.20 -> r1.21)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out.diff?r1=1.20&r2=1.21)
plpgsql.out (r1.54 -> r1.55)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plpgsql.out.diff?r1=1.54&r2=1.55)
transactions.out (r1.15 -> r1.16)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/transactions.out.diff?r1=1.15&r2=1.16)
uuid.out (r1.2 -> r1.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/uuid.out.diff?r1=1.2&r2=1.3)
pgsql/src/test/regress/output:
constraints.source (r1.42 -> r1.43)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/output/constraints.source.diff?r1=1.42&r2=1.43)
tablespace.source (r1.4 -> r1.5)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/output/tablespace.source.diff?r1=1.4&r2=1.5)


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Clarify some error messages about duplicate things.
Date: 2007-06-04 04:16:37
Message-ID: 2192.1180930597@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> Clarify some error messages about duplicate things.

This patch missed updating the expected output for ecpg ...

regards, tom lane


From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Peter Eisentraut" <petere(at)postgresql(dot)org>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Clarify some error messages about duplicate things.
Date: 2007-06-04 13:14:38
Message-ID: 87ira3uaip.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

"Peter Eisentraut" <petere(at)postgresql(dot)org> writes:

> Log Message:
> -----------
> Clarify some error messages about duplicate things.

Could we hold off on these kinds of cosmetic fixups that touch dozens of files
until we're done processing the largish patches in the queue? They cause lots
of bitrot and it's a pain when a large hunk of a complex patch fails because
of some one-line cosmetic change.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Clarify some error messages about duplicate things.
Date: 2007-06-04 15:04:38
Message-ID: 200706041704.38768.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Am Montag, 4. Juni 2007 15:14 schrieb Gregory Stark:
> Could we hold off on these kinds of cosmetic fixups that touch dozens of
> files until we're done processing the largish patches in the queue?

I think we could.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/