| Lists: | pgsql-patches |
|---|
| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Synchronized Scan |
| Date: | 2007-05-20 22:01:32 |
| Message-ID: | 1179698492.2771.114.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Here is the latest version of my patch that's revised according to my
discussions with Heikki and Simon:
Changes:
* uses LWLocks when accessing shared memory
* removes the "sync_seqscan_offset" feature
* uses the relfilenode as a key rather than relation OID
* fixes regression test failure
* uses a simple LRU (that stays in fixed-size shared memory) to track
the locations of other concurrent scans
For the LRU I used a doubly-linked list, which isn't strictly necessary.
However, we may decide to use a hash table for the lookup, in which case
the extra pointers will be useful.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| syncscan20.patch | text/x-patch | 19.2 KB |
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Synchronized Scan |
| Date: | 2007-05-21 14:03:02 |
| Message-ID: | 200705211603.03365.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Am Montag, 21. Mai 2007 00:01 schrieb Jeff Davis:
> Here is the latest version of my patch that's revised according to my
> discussions with Heikki and Simon:
This patch was apparently done against 8.2.4, but it doesn't apply to CVS
head.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Synchronized Scan |
| Date: | 2007-05-21 15:24:21 |
| Message-ID: | 1179761061.2771.124.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Mon, 2007-05-21 at 16:03 +0200, Peter Eisentraut wrote:
> Am Montag, 21. Mai 2007 00:01 schrieb Jeff Davis:
> > Here is the latest version of my patch that's revised according to my
> > discussions with Heikki and Simon:
>
> This patch was apparently done against 8.2.4, but it doesn't apply to CVS
> head.
>
Thanks. Here's a version that applies cleanly to CVS head.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| syncscan20-cvshead.patch | text/x-patch | 19.1 KB |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Synchronized Scan |
| Date: | 2007-05-22 17:15:00 |
| Message-ID: | 200705221715.l4MHF0d17372@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Jeff Davis wrote:
> On Mon, 2007-05-21 at 16:03 +0200, Peter Eisentraut wrote:
> > Am Montag, 21. Mai 2007 00:01 schrieb Jeff Davis:
> > > Here is the latest version of my patch that's revised according to my
> > > discussions with Heikki and Simon:
> >
> > This patch was apparently done against 8.2.4, but it doesn't apply to CVS
> > head.
> >
>
> Thanks. Here's a version that applies cleanly to CVS head.
>
> Regards,
> Jeff Davis
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +