Lists: | pgsql-committerspgsql-hackers |
---|
From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Remove some of the most blatant brain-fade in the recent guc |
Date: | 2007-04-22 03:52:40 |
Message-ID: | 20070422035240.878119FB33C@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-committers pgsql-hackers |
Log Message:
-----------
Remove some of the most blatant brain-fade in the recent guc patch
(it's so nice to have a buildfarm member that actively rejects naked
uses of strcasecmp). This coding is still pretty awful, though, since
it's going to be O(N^2) in the number of guc variables. May I direct
your attention to bsearch?
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc.c (r1.387 -> r1.388)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.387&r2=1.388)
From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)postgresql(dot)org> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc |
Date: | 2007-04-27 02:47:20 |
Message-ID: | 200704270247.l3R2lKE04897@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-committers pgsql-hackers |
Is anyone working on this fix?
---------------------------------------------------------------------------
Tom Lane wrote:
> Log Message:
> -----------
> Remove some of the most blatant brain-fade in the recent guc patch
> (it's so nice to have a buildfarm member that actively rejects naked
> uses of strcasecmp). This coding is still pretty awful, though, since
> it's going to be O(N^2) in the number of guc variables. May I direct
> your attention to bsearch?
>
> Modified Files:
> --------------
> pgsql/src/backend/utils/misc:
> guc.c (r1.387 -> r1.388)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.387&r2=1.388)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc |
Date: | 2007-04-27 03:19:15 |
Message-ID: | 3030.1177643955@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Is anyone working on this fix?
I dunno, but that patch is gonna get reverted altogether if someone
doesn't fix the fact that it broke PGCLIENTENCODING ...
regards, tom lane