| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Optimized pgbench for 8.3 |
| Date: | 2007-03-05 07:11:12 |
| Message-ID: | 20070305154413.C4B1.ITAGAKI.TAKAHIRO@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
The attached is a patch to optimize contrib/pgbench using new 8.3 features.
- Use DROP IF EXISTS to suppress errors for initial loadings.
- Use a combination of TRUNCATE and COPY to reduce WAL on creating
the accounts table.
Also, there are some cosmetic changes.
- Change the output of -v option from "starting full vacuum..."
to "starting vacuum accounts..." in reflection of the fact.
- Shape duplicated error checks into executeStatement().
There is a big performance win in "COPY with no WAL" feature.
Thanks for the efforts!
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-8.3.patch | application/octet-stream | 10.6 KB |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-03-25 01:44:47 |
| Message-ID: | 200703250144.l2P1il206064@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
ITAGAKI Takahiro wrote:
> The attached is a patch to optimize contrib/pgbench using new 8.3 features.
>
> - Use DROP IF EXISTS to suppress errors for initial loadings.
> - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> the accounts table.
>
> Also, there are some cosmetic changes.
>
> - Change the output of -v option from "starting full vacuum..."
> to "starting vacuum accounts..." in reflection of the fact.
> - Shape duplicated error checks into executeStatement().
>
>
> There is a big performance win in "COPY with no WAL" feature.
> Thanks for the efforts!
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-05 02:10:38 |
| Message-ID: | 200704050210.l352AcY02670@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Tatsuo, would you please comment on this patch?
---------------------------------------------------------------------------
ITAGAKI Takahiro wrote:
> The attached is a patch to optimize contrib/pgbench using new 8.3 features.
>
> - Use DROP IF EXISTS to suppress errors for initial loadings.
> - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> the accounts table.
>
> Also, there are some cosmetic changes.
>
> - Change the output of -v option from "starting full vacuum..."
> to "starting vacuum accounts..." in reflection of the fact.
> - Shape duplicated error checks into executeStatement().
>
>
> There is a big performance win in "COPY with no WAL" feature.
> Thanks for the efforts!
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | bruce(at)momjian(dot)us |
| Cc: | itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, ishii(at)sraoss(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-05 02:15:37 |
| Message-ID: | 20070405.111537.69453357.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
> Tatsuo, would you please comment on this patch?
Sure. I will come up with a comment by the end of this week.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
> ---------------------------------------------------------------------------
>
> ITAGAKI Takahiro wrote:
> > The attached is a patch to optimize contrib/pgbench using new 8.3 features.
> >
> > - Use DROP IF EXISTS to suppress errors for initial loadings.
> > - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> > the accounts table.
> >
> > Also, there are some cosmetic changes.
> >
> > - Change the output of -v option from "starting full vacuum..."
> > to "starting vacuum accounts..." in reflection of the fact.
> > - Shape duplicated error checks into executeStatement().
> >
> >
> > There is a big performance win in "COPY with no WAL" feature.
> > Thanks for the efforts!
> >
> > Regards,
> > ---
> > ITAGAKI Takahiro
> > NTT Open Source Software Center
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: don't forget to increase your free space map settings
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | bruce(at)momjian(dot)us, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-06 02:35:30 |
| Message-ID: | 20070406.113530.118771693.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
> > Tatsuo, would you please comment on this patch?
>
> Sure. I will come up with a comment by the end of this week.
The patches look good to me.
BTW, is anybody working on enabling the fill factor to the tables used
by pgbench? 8.3 will introduce HOT, and I think adding the feature
will make it easier to test HOT.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
> > ---------------------------------------------------------------------------
> >
> > ITAGAKI Takahiro wrote:
> > > The attached is a patch to optimize contrib/pgbench using new 8.3 features.
> > >
> > > - Use DROP IF EXISTS to suppress errors for initial loadings.
> > > - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> > > the accounts table.
> > >
> > > Also, there are some cosmetic changes.
> > >
> > > - Change the output of -v option from "starting full vacuum..."
> > > to "starting vacuum accounts..." in reflection of the fact.
> > > - Shape duplicated error checks into executeStatement().
> > >
> > >
> > > There is a big performance win in "COPY with no WAL" feature.
> > > Thanks for the efforts!
> > >
> > > Regards,
> > > ---
> > > ITAGAKI Takahiro
> > > NTT Open Source Software Center
> >
> > [ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 5: don't forget to increase your free space map settings
> >
> > --
> > Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> > EnterpriseDB http://www.enterprisedb.com
> >
> > + If your life is a hard drive, Christ can be your backup. +
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, bruce(at)momjian(dot)us, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-06 06:08:59 |
| Message-ID: | 28672.1175839739@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
> The patches look good to me.
Please commit whatever you think is reasonable.
> BTW, is anybody working on enabling the fill factor to the tables used
> by pgbench? 8.3 will introduce HOT, and I think adding the feature
> will make it easier to test HOT.
I'm not 100% sure that HOT will make it ... but I agree that it'd be
useful for pgbench to support different fillfactor choices. Please
add if you have time.
regards, tom lane
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp |
| Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-06 12:59:49 |
| Message-ID: | 20070406.215949.45965181.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Patch committed. Thanks.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
> The attached is a patch to optimize contrib/pgbench using new 8.3 features.
>
> - Use DROP IF EXISTS to suppress errors for initial loadings.
> - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> the accounts table.
>
> Also, there are some cosmetic changes.
>
> - Change the output of -v option from "starting full vacuum..."
> to "starting vacuum accounts..." in reflection of the fact.
> - Shape duplicated error checks into executeStatement().
>
>
> There is a big performance win in "COPY with no WAL" feature.
> Thanks for the efforts!
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Optimized pgbench for 8.3 |
| Date: | 2007-04-07 02:52:07 |
| Message-ID: | 200704070252.l372q7r04302@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
FYI, patch applied by Tatsuo. Thanks.
---------------------------------------------------------------------------
ITAGAKI Takahiro wrote:
> The attached is a patch to optimize contrib/pgbench using new 8.3 features.
>
> - Use DROP IF EXISTS to suppress errors for initial loadings.
> - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> the accounts table.
>
> Also, there are some cosmetic changes.
>
> - Change the output of -v option from "starting full vacuum..."
> to "starting vacuum accounts..." in reflection of the fact.
> - Shape duplicated error checks into executeStatement().
>
>
> There is a big performance win in "COPY with no WAL" feature.
> Thanks for the efforts!
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | "Tatsuo Ishii" <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, bruce(at)momjian(dot)us, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Optimized pgbench for 8.3 |
| Date: | 2007-04-07 16:58:23 |
| Message-ID: | 2e78013d0704070958g7d9f0eddu8e2510a335e4f804@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On 4/6/07, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
>
> BTW, is anybody working on enabling the fill factor to the tables used
> by pgbench? 8.3 will introduce HOT, and I think adding the feature
> will make it easier to test HOT.
>
>
Please see if the attached patch looks good. It adds a new -F option
which can be used to set fillfactor for tellers, accounts and branches
tables. Default is 100 and anything between 10 and 100 is acceptable.
Thanks,
Pavan
--
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench_fillfactor.patch | application/octet-stream | 5.1 KB |
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | pavan(dot)deolasee(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org, bruce(at)momjian(dot)us, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Optimized pgbench for 8.3 |
| Date: | 2007-04-08 01:17:02 |
| Message-ID: | 20070408.101702.98341071.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Patch committed. Thanks.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
> On 4/6/07, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> >
> >
> > BTW, is anybody working on enabling the fill factor to the tables used
> > by pgbench? 8.3 will introduce HOT, and I think adding the feature
> > will make it easier to test HOT.
> >
> >
> Please see if the attached patch looks good. It adds a new -F option
> which can be used to set fillfactor for tellers, accounts and branches
> tables. Default is 100 and anything between 10 and 100 is acceptable.
>
> Thanks,
> Pavan
>
> --
>
> EnterpriseDB http://www.enterprisedb.com