Re: pg_ctl options

Lists: pgsql-hackers
From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_ctl options
Date: 2007-01-03 14:12:10
Message-ID: 459BB9BA.1010502@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I notice that quite a few pg_ctl options have no long form equivalents,
namely these: NopPwW

Also, none of the long forms seems to be documented at all.

Should this be cleared up (maybe a nice first project for lurking new
contributors)?\

If we don't want long forms for some reason, then a comment in the code
saying why would make sense.

cheers

andrew


From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_ctl options
Date: 2007-01-04 02:07:44
Message-ID: 20070104020744.GC3066@timbira.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andrew Dunstan wrote:

> Should this be cleared up (maybe a nice first project for lurking new
> contributors)?\
>
Maybe.

> If we don't want long forms for some reason, then a comment in the code
> saying why would make sense.
>
I don't see a strong reason for not to do it. But if you look closely at
the postgres binaries you'll notice some "inconsistencies" e.g.,
pg_ctl doesn't have long options, pg_config doesn't have short options,
postgres almost don't have long options. I agree that it deserves a
cleanup but I don't know if it's worth to do.

--
Euler Taveira de Oliveira
http://www.timbira.com/


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_ctl options
Date: 2007-01-06 22:18:33
Message-ID: 200701062218.l06MIXW06453@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Added to TODO:

* Make consistent use of long/short command options --- pg_ctl needs
long ones, pg_config doesn't have short ones, postgres doesn't have
enough long ones, etc.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
> I notice that quite a few pg_ctl options have no long form equivalents,
> namely these: NopPwW
>
> Also, none of the long forms seems to be documented at all.
>
> Should this be cleared up (maybe a nice first project for lurking new
> contributors)?\
>
> If we don't want long forms for some reason, then a comment in the code
> saying why would make sense.
>
> cheers
>
> andrew
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-06 23:05:33
Message-ID: 200701070005.34839.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian wrote:
> Added to TODO:
>
> * Make consistent use of long/short command options --- pg_ctl needs
> long ones, pg_config doesn't have short ones, postgres doesn't have
> enough long ones, etc.

Certainly postgres has plenty of long ones. And I don't know why
pg_config would need short ones.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-06 23:12:43
Message-ID: 200701062312.l06NCho10290@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > Added to TODO:
> >
> > * Make consistent use of long/short command options --- pg_ctl needs
> > long ones, pg_config doesn't have short ones, postgres doesn't have
> > enough long ones, etc.
>
> Certainly postgres has plenty of long ones. And I don't know why

I don't see them.

> pg_config would need short ones.

Seems we should have some, though you could make the case it has too
many options to support single letters.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-06 23:55:37
Message-ID: 200701070055.38087.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian wrote:
> > pg_config would need short ones.
>
> Seems we should have some,

But why? What is the use case? It's not like pg_config is a frequently
typed command.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-07 01:14:30
Message-ID: 200701070114.l071EUX21320@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > > pg_config would need short ones.
> >
> > Seems we should have some,
>
> But why? What is the use case? It's not like pg_config is a frequently
> typed command.

I thought consistency. Why do any of the commands have long and short
options?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-07 02:10:58
Message-ID: 1168135858.869.5.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, 2007-01-06 at 20:14 -0500, Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > Bruce Momjian wrote:
> > > > pg_config would need short ones.
> > >
> > > Seems we should have some,
> >
> > But why? What is the use case? It's not like pg_config is a frequently
> > typed command.
>
> I thought consistency. Why do any of the commands have long and short
> options?

That would be my argument. Consistency is good.

Joshua D. Drake

>
>
--

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive PostgreSQL solutions since 1997
http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_ctl options
Date: 2007-01-07 02:27:55
Message-ID: 2127.1168136875@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Peter Eisentraut wrote:
>> Certainly postgres has plenty of long ones. And I don't know why

> I don't see them.

postgres/postmaster accept --any-guc-variable=value. AFAIR all the
single-letter options these days are equivalent to one of those.
There's not anything else to do there, except perhaps fix the
documentation (I'm not clear on why Table 17-1 is where it is and
not on the postgres command reference page).

I can't get excited about inventing short options for pg_config.

regards, tom lane