| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | gratuituous string difference |
| Date: | 2006-11-29 19:09:59 |
| Message-ID: | 20061129190959.GB6947@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
This patch fixes a gratuituous string difference. Barring objections
I'll apply shortly.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| Attachment | Content-Type | Size |
|---|---|---|
| typecmds.patch | text/plain | 941 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: gratuituous string difference |
| Date: | 2006-11-29 19:34:09 |
| Message-ID: | 21858.1164828849@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This patch fixes a gratuituous string difference. Barring objections
> I'll apply shortly.
I object. We do not quote the output of format_type_be() ... look at
its code to see why not.
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: gratuituous string difference |
| Date: | 2006-11-29 19:44:52 |
| Message-ID: | 20061129194452.GB7001@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > This patch fixes a gratuituous string difference. Barring objections
> > I'll apply shortly.
>
> I object. We do not quote the output of format_type_be() ... look at
> its code to see why not.
Oh, I see -- it may add double quotes on its own in certain cases, while
the other string gets the input from TypeNameToString which never does.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support