Re: Mark change-on-restart-only values in postgresql.conf

I added additional comments marked setting which need server restart to
take effect. I use (!RSR!) tag for it, however if anybody have different
idea, let me know and I will change it.

I removed comments about commenting out behavior too, because patch now
waiting for commit (or reject?).

Zdenek

On Tuesday 18 July 2006 17:44, Zdenek Kotala wrote:
> I added additional comments marked setting which need server restart to
> take effect. I use (!RSR!) tag for it, however if anybody have different
> idea, let me know and I will change it.
>

Out of curisoity, does the !RSR! actually have some meaning? !RRS (requires
restart) or !RR or !RS (restart) all seem more straightforward.

More importantly, I think you need to mark all of the variables with the
special tag individually, as opposed to where, like in the kerberos settings,
you just say "all kerberose settings require restart". This is mainly
because...

> I removed comments about commenting out behavior too, because patch now
> waiting for commit (or reject?).

I know some setups remove all commented options from the postgresql.conf, so
that only modified parameters are left inside the postgresql.conf. If they
want to change a setting, they add it into the conf. I think the theory is
that this is either more secure, since it would require more knowledge to
modify the postgres settings this way, or it is a nod to making
postgresql.conf more portable accross versions (by keeping a smaller subset
of changes its more likely they will work across versions) or in an effort to
make the postgresql.conf simpler (by removing a lot of variables that will
never be modified)... in any case it is a valid setup in 8.1, unfortunatly I
haven't had time to test your patch with CVS, but do you know if it can
support those types of configurations?

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

>
> I removed comments about commenting out behavior too, because patch now
> waiting for commit (or reject?).
>
>
> Zdenek
>

not a big deal but, i think, you should remove this in the patch that
implements that behavior rather than in a newer one that still must be
discussed.

BTW, you have a typo in this line

+ # All file locations settings change require server restart to tak effect.

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

Am Dienstag, 18. Juli 2006 23:44 schrieb Zdenek Kotala:
> I added additional comments marked setting which need server restart to
> take effect. I use (!RSR!) tag for it, however if anybody have different
> idea, let me know and I will change it.

It seems that people didn't like introducing secret codes into the
configuration file, so I adapted your patch and changed the marker
to "(change requires restart)".

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Peter Eisentraut wrote:
> Am Dienstag, 18. Juli 2006 23:44 schrieb Zdenek Kotala:
>> I added additional comments marked setting which need server restart to
>> take effect. I use (!RSR!) tag for it, however if anybody have different
>> idea, let me know and I will change it.
>
> It seems that people didn't like introducing secret codes into the
> configuration file, so I adapted your patch and changed the marker
> to "(change requires restart)".
>

OK, I going to change. Is there any limit to char per line?

Zdenek

Am Montag, 24. Juli 2006 12:25 schrieb Zdenek Kotala:
> OK, I going to change. Is there any limit to char per line?

It's already committed.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Peter Eisentraut wrote:
> Am Montag, 24. Juli 2006 12:25 schrieb Zdenek Kotala:
>> OK, I going to change. Is there any limit to char per line?
>
> It's already committed.
>

Oh, excellent. Thanks