| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | momjian(at)postgresql(dot)org (Bruce Momjian) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df |
| Date: | 2006-07-18 18:20:51 |
| Message-ID: | 20060718182051.A0FBD9FA004@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Log Message:
-----------
Done:
o -Display IN, INOUT, and OUT parameters in \df
Modified Files:
--------------
pgsql/doc:
TODO (r1.1914 -> r1.1915)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1914&r2=1.1915)
pgsql/doc/src/FAQ:
TODO.html (r1.417 -> r1.418)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.417&r2=1.418)
| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Bruce Momjian <momjian(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df |
| Date: | 2006-07-18 20:21:53 |
| Message-ID: | 20060718202153.GA22801@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
> Log Message:
> -----------
> Done:
>
> o -Display IN, INOUT, and OUT parameters in \df
Oops! Should I change the patch to say IN when it's an IN parameter?
Right now, it stays silent.
Cheers,
D
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT |
| Date: | 2006-07-18 22:07:01 |
| Message-ID: | 200607182207.k6IM71i04274@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
David Fetter wrote:
> On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Done:
> >
> > o -Display IN, INOUT, and OUT parameters in \df
>
> Oops! Should I change the patch to say IN when it's an IN parameter?
> Right now, it stays silent.
[ Moved to hackers.] No idea. Comments?
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | David Fetter <david(at)fetter(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, |
| Date: | 2006-07-18 22:54:49 |
| Message-ID: | 44BD66B9.9060609@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian wrote:
> David Fetter wrote:
>
>> On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
>>
>>> Log Message:
>>> -----------
>>> Done:
>>>
>>> o -Display IN, INOUT, and OUT parameters in \df
>>>
>> Oops! Should I change the patch to say IN when it's an IN parameter?
>> Right now, it stays silent.
>>
>
> [ Moved to hackers.] No idea. Comments?
>
>
Actually, I'd be inclined to put IN if there are INOUT or OUT
parameters, and nothing if they are all IN parameters, but I realise
this might seem inconsistent.
cheers
andrew
| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df |
| Date: | 2006-07-18 23:32:22 |
| Message-ID: | 20060718233222.GA22503@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:
> David Fetter wrote:
> > On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Done:
> > >
> > > o -Display IN, INOUT, and OUT parameters in \df
> >
> > Oops! Should I change the patch to say IN when it's an IN
> > parameter? Right now, it stays silent.
>
> [ Moved to hackers.] No idea. Comments?
I'm thinking "no." Parameters by default are unnamed IN parameters,
so I exposed and marked things which differed from that. :)
Cheers,
D
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df |
| Date: | 2006-07-19 00:11:44 |
| Message-ID: | 21868.1153267904@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
David Fetter <david(at)fetter(dot)org> writes:
> On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:
>> [ Moved to hackers.] No idea. Comments?
> I'm thinking "no." Parameters by default are unnamed IN parameters,
> so I exposed and marked things which differed from that. :)
I agree; the patch already makes \df more noisy than some would wish.
regards, tom lane