Re: Compile libpq with vc8

When is this patch going to be applied? Is there a bug that I can
follow along?

thanks.

jeff

* From: Bruce Momjian <pgman ( at ) candle ( dot ) pha ( dot ) pa (
dot ) us>
* To: Yannick <ybgn ( at ) free ( dot ) fr>
* Subject: Re: Compile libpq with vc8
* Date: Mon, 29 May 2006 15:39:50 -0400 (EDT)

Yes, I have a patch in the queue to fix it. Should be applied soon.

---------------------------------------------------------------------------

Yannick wrote:
> Hi,
>
> I am trying to compile libpq with vc8. I got errors in wchar.c
>
> ..\..\backend\utils\mb\wchar.c(99) : error C2054: expected '(' to follow
> 'inline'
> ..\..\backend\utils\mb\wchar.c(100) : error C2085: 'pg_euc_mblen' : not
> in formal parameter list
> ..\..\backend\utils\mb\wchar.c(100) : error C2143: syntax error :
> missing ';' before '{'
>
>
> If I remove the "inline", I got an error in:
>
> [...]postgresql-8.1.4\src\include\utils/elog.h(105) : error C2365:
> 'errcode' : redefinition; previous definition was 'typedef'
>
> Does anyone already compiled libpq with vc8?
>
> Yannick.
>

It was applied 24-hours ago, and should be in CVS HEAD and the 8.1
stable branch.

---------------------------------------------------------------------------

Jeff McKenna wrote:
> When is this patch going to be applied? Is there a bug that I can
> follow along?
>
> thanks.
>
> jeff
>
>
>
>
> * From: Bruce Momjian <pgman ( at ) candle ( dot ) pha ( dot ) pa (
> dot ) us>
> * To: Yannick <ybgn ( at ) free ( dot ) fr>
> * Subject: Re: Compile libpq with vc8
> * Date: Mon, 29 May 2006 15:39:50 -0400 (EDT)
>
> Yes, I have a patch in the queue to fix it. Should be applied soon.
>
> ---------------------------------------------------------------------------
>
> Yannick wrote:
> > Hi,
> >
> > I am trying to compile libpq with vc8. I got errors in wchar.c
> >
> > ..\..\backend\utils\mb\wchar.c(99) : error C2054: expected '(' to follow
> > 'inline'
> > ..\..\backend\utils\mb\wchar.c(100) : error C2085: 'pg_euc_mblen' : not
> > in formal parameter list
> > ..\..\backend\utils\mb\wchar.c(100) : error C2143: syntax error :
> > missing ';' before '{'
> >
> >
> > If I remove the "inline", I got an error in:
> >
> > [...]postgresql-8.1.4\src\include\utils/elog.h(105) : error C2365:
> > 'errcode' : redefinition; previous definition was 'typedef'
> >
> > Does anyone already compiled libpq with vc8?
> >
> > Yannick.
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
>

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> It was applied 24-hours ago, and should be in CVS HEAD and the 8.1
> stable branch.
>
I downloaded the source, following the instructions at
http://www.postgresql.org/developer/sourcecode/. It seems I didn't get
your commit :(

Log for win32.mak:
revision 1.36
date: 2005/09/16 18:58:48; author: momjian; state: Exp; lines: +1 -4
This correction is required of nmake of Windows.

Did I check out the correct branch?

Yannick.

Yannick wrote:
> Bruce Momjian wrote:
>> It was applied 24-hours ago, and should be in CVS HEAD and the 8.1
>> stable branch.
>>
> I downloaded the source, following the instructions at
> http://www.postgresql.org/developer/sourcecode/. It seems I didn't get
> your commit :(
>
> Log for win32.mak:
> revision 1.36
> date: 2005/09/16 18:58:48; author: momjian; state: Exp; lines: +1 -4
> This correction is required of nmake of Windows.
>
> Did I check out the correct branch?
>

The fix didn't touch the makefile. It supplied a definition for inline
in the config header file.

see http://archives.postgresql.org/pgsql-committers/2006-05/msg00351.php

cheers

andrew