Re: BUG #2420: NetBSD doesn't need float8-small-is-zero regression

Lists: pgsql-bugs
From: "Simon Burge" <simonb(at)netbsd(dot)org>
To: pgsql-bugs(at)postgresql(dot)org
Subject: BUG #2420: NetBSD doesn't need float8-small-is-zero regression test resultmap entry
Date: 2006-05-04 06:49:54
Message-ID: 200605040649.k446nsE3085178@wwwmaster.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs


The following bug has been logged online:

Bug reference: 2420
Logged by: Simon Burge
Email address: simonb(at)netbsd(dot)org
PostgreSQL version: 8.1.3
Operating system: NetBSD 3.0/i386
Description: NetBSD doesn't need float8-small-is-zero regression test
resultmap entry
Details:

NetBSD doesn't need the float8-small-is-zero entry in the
src/test/regress/resultmap file any more.

It looks like the entry was added in rev 1.17 in 2000. I don't know what
has changed from NetBSD's point of view in this time, but removing this
entry means the float8 test now passes.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Simon Burge <simonb(at)netbsd(dot)org>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #2420: NetBSD doesn't need float8-small-is-zero regression
Date: 2006-05-05 16:18:40
Message-ID: 200605051618.k45GIe024597@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs


Thanks for the feedback.

Patch attached, so NetBSD >= 3.0 will not use float8-small-is-zero.

I assume m68k is also fixed. If not, we will hear about it.

Applied to CVS HEAD and 8.1.X.

---------------------------------------------------------------------------

Simon Burge wrote:
>
> The following bug has been logged online:
>
> Bug reference: 2420
> Logged by: Simon Burge
> Email address: simonb(at)netbsd(dot)org
> PostgreSQL version: 8.1.3
> Operating system: NetBSD 3.0/i386
> Description: NetBSD doesn't need float8-small-is-zero regression test
> resultmap entry
> Details:
>
> NetBSD doesn't need the float8-small-is-zero entry in the
> src/test/regress/resultmap file any more.
>
> It looks like the entry was added in rev 1.17 in 2000. I don't know what
> has changed from NetBSD's point of view in this time, but removing this
> entry means the float8 test now passes.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
>

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/bjm/diff text/x-diff 1.1 KB
From: Kris Jurka <books(at)ejurka(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: simonb(at)netbsd(dot)org, jeffrey(dot)tacy(at)gmail(dot)com
Subject: Re: BUG #2420: NetBSD doesn't need float8-small-is-zero regression
Date: 2006-05-05 17:05:47
Message-ID: 445B85EB.1000809@ejurka.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Bruce Momjian wrote:
> Thanks for the feedback.
>
> Patch attached, so NetBSD >= 3.0 will not use float8-small-is-zero.
>

The buildfarm seems to think this is a bad idea.

http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=gazelle&dt=2006-05-05%2016:30:00

Kris Jurka