| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | Matteo Beccati <php(at)beccati(dot)com> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: Enhanced containment selectivity function |
| Date: | 2006-03-10 11:36:13 |
| Message-ID: | 441164AD.1080707@beccati.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian ha scritto:
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
Great. I would just like to remind that Tom said:
> I'd be willing to consider exporting those functions from selfuncs.c.
so that the selector function could be moved to contrib/ltree, which is
its natural place.
It could also be noted that a similar feature could be useful outside
ltree: I guess there are plenty of cases when scanning statistics would
give a better result than using a constant selectivity.
Best regards
--
Matteo Beccati
http://phpadsnew.com
http://phppgads.com
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Matteo Beccati <php(at)beccati(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: Enhanced containment selectivity function |
| Date: | 2006-03-10 18:28:15 |
| Message-ID: | 200603101828.k2AISGg15531@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Matteo Beccati wrote:
> Bruce Momjian ha scritto:
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> > http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > It will be applied as soon as one of the PostgreSQL committers reviews
> > and approves it.
>
> Great. I would just like to remind that Tom said:
>
> > I'd be willing to consider exporting those functions from selfuncs.c.
>
> so that the selector function could be moved to contrib/ltree, which is
> its natural place.
>
> It could also be noted that a similar feature could be useful outside
> ltree: I guess there are plenty of cases when scanning statistics would
> give a better result than using a constant selectivity.
Yes, I talked to Tom today about moving that stuff into /contrib. I
will work on the patch to do that.
--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Matteo Beccati <php(at)beccati(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Enhanced containment selectivity function |
| Date: | 2006-04-26 22:32:01 |
| Message-ID: | 200604262232.k3QMW1018118@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Matteo Beccati wrote:
> Bruce Momjian ha scritto:
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> > http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > It will be applied as soon as one of the PostgreSQL committers reviews
> > and approves it.
>
> Great. I would just like to remind that Tom said:
>
> > I'd be willing to consider exporting those functions from selfuncs.c.
>
> so that the selector function could be moved to contrib/ltree, which is
> its natural place.
>
> It could also be noted that a similar feature could be useful outside
> ltree: I guess there are plenty of cases when scanning statistics would
> give a better result than using a constant selectivity.
I have done as you and Tom suggested, moving parentsel into
/contrib/ltree. Patch attached and applied, catalog version attached.
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /bjm/diff | text/x-patch | 21.7 KB |