Re: ALTER CONSTRAINT RENAME patch reverted

Log Message:
-----------
Allow ALTER TABLE ... ALTER CONSTRAINT ... RENAME

Joachim Wieland

Modified Files:
--------------
pgsql/doc/src/sgml:
ddl.sgml (r1.52 -> r1.53)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ddl.sgml.diff?r1=1.52&r2=1.53)
pgsql/doc/src/sgml/ref:
alter_index.sgml (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/alter_index.sgml.diff?r1=1.6&r2=1.7)
alter_table.sgml (r1.82 -> r1.83)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/alter_table.sgml.diff?r1=1.82&r2=1.83)
pgsql/src/backend/catalog:
pg_constraint.c (r1.28 -> r1.29)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_constraint.c.diff?r1=1.28&r2=1.29)
pg_depend.c (r1.17 -> r1.18)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_depend.c.diff?r1=1.17&r2=1.18)
pgsql/src/backend/commands:
alter.c (r1.15 -> r1.16)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/alter.c.diff?r1=1.15&r2=1.16)
pgsql/src/backend/parser:
gram.y (r2.526 -> r2.527)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y.diff?r1=2.526&r2=2.527)
pgsql/src/backend/tcop:
utility.c (r1.250 -> r1.251)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/utility.c.diff?r1=1.250&r2=1.251)
pgsql/src/include/catalog:
dependency.h (r1.18 -> r1.19)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/dependency.h.diff?r1=1.18&r2=1.19)
pg_constraint.h (r1.19 -> r1.20)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_constraint.h.diff?r1=1.19&r2=1.20)
pgsql/src/test/regress/expected:
alter_table.out (r1.90 -> r1.91)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out.diff?r1=1.90&r2=1.91)
pgsql/src/test/regress/sql:
alter_table.sql (r1.52 -> r1.53)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/alter_table.sql.diff?r1=1.52&r2=1.53)

momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Log Message:
> -----------
> Allow ALTER TABLE ... ALTER CONSTRAINT ... RENAME

This patch appears seriously broken, in particular every routine I
looked at contained incorrect locking assumptions. Nor do I care
for using pg_depend for the purposes it's being used for here.

regards, tom lane

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Allow ALTER TABLE ... ALTER CONSTRAINT ... RENAME
>
> This patch appears seriously broken, in particular every routine I
> looked at contained incorrect locking assumptions. Nor do I care
> for using pg_depend for the purposes it's being used for here.

OK, how do we proceed? Revert or apply a second patch?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> This patch appears seriously broken, in particular every routine I
>> looked at contained incorrect locking assumptions. Nor do I care
>> for using pg_depend for the purposes it's being used for here.

> OK, how do we proceed? Revert or apply a second patch?

I'd say revert; the patch is going to need significant rework.

regards, tom lane

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> This patch appears seriously broken, in particular every routine I
> >> looked at contained incorrect locking assumptions. Nor do I care
> >> for using pg_depend for the purposes it's being used for here.
>
> > OK, how do we proceed? Revert or apply a second patch?
>
> I'd say revert; the patch is going to need significant rework.

OK, patch reverted. Updated version attached. Please adjust and
resubmit. Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Where are we on this patch. It was reverted. I someone going to clean
it up so we can apply it?

---------------------------------------------------------------------------

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Tom Lane wrote:
> > >> This patch appears seriously broken, in particular every routine I
> > >> looked at contained incorrect locking assumptions. Nor do I care
> > >> for using pg_depend for the purposes it's being used for here.
> >
> > > OK, how do we proceed? Revert or apply a second patch?
> >
> > I'd say revert; the patch is going to need significant rework.
>
> OK, patch reverted. Updated version attached. Please adjust and
> resubmit. Thanks.
>

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +