| Lists: | pgsql-hackers |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: psql & readline & win32 |
| Date: | 2006-02-13 18:06:58 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0F785@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> >> What would we patch it with? I don't think anybody has found a
> >> problem there, this is a separate file that you ship along with it.
>
> > Well, the problem is that it handles backslash incorrectly.
> We could
> > patch that in the readline source rather than playing with a
> > configuaration file.
>
> Do the readline developers agree that it's "incorrect"? I
> could see shipping a patch as a short-term band-aid, but not
> if the patch isn't going to be accepted upstream.
I have seen no such agreement. The ability to reconfigure the keys is
definitly a feature, so it could perhaps be argued to be that. In
general, I don't think they care too much about win32 :-( Which is
another thing that makes libedit a lot more encouraging - if it could be
made working.
Bruce wrote:
> I think what we don't have is saving history between psql uses.
We do keep history if the new psql is startede in the same
commandprompt. If you start a new cmd, history gets reset. (Which is
what happens if you start it from the start menu)
//Magnus
//Magnus
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql & readline & win32 |
| Date: | 2006-02-13 18:09:57 |
| Message-ID: | 200602131809.k1DI9vF03205@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Magnus Hagander wrote:
> > >> What would we patch it with? I don't think anybody has found a
> > >> problem there, this is a separate file that you ship along with it.
> >
> > > Well, the problem is that it handles backslash incorrectly.
> > We could
> > > patch that in the readline source rather than playing with a
> > > configuaration file.
> >
> > Do the readline developers agree that it's "incorrect"? I
> > could see shipping a patch as a short-term band-aid, but not
> > if the patch isn't going to be accepted upstream.
>
> I have seen no such agreement. The ability to reconfigure the keys is
> definitly a feature, so it could perhaps be argued to be that. In
> general, I don't think they care too much about win32 :-( Which is
> another thing that makes libedit a lot more encouraging - if it could be
> made working.
I would love us to use libedit more, and our configure flags for libedit
are improved in 8.2.
> > I think what we don't have is saving history between psql uses.
>
> We do keep history if the new psql is startede in the same
> commandprompt. If you start a new cmd, history gets reset. (Which is
> what happens if you start it from the start menu)
Ah, OK, I was testing from the start menu.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073