Re: Odbcapi30.c - 64 bit compiler warning cleanup

> -----Original Message-----
> From: Ludek Finstrle [mailto:luf(at)pzkagis(dot)cz]
> Sent: 19 January 2006 11:24
> To: Dave Page
> Cc: pgsql-odbc(at)postgresql(dot)org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
> > The attached patch cleans up the 64 bit compiler warnings in
> > odbcapi30.c.
>
> I'll try it today or tomorrow (I hope).

Thanks - I should add that I'm not sure how to deal with the other ones.
I think it needs someone far more experienced in 32/64 bit issues than
me to think about it.

Regards, Dave.

> > > The attached patch cleans up the 64 bit compiler warnings in
> > > odbcapi30.c.
> >
> > I'll try it today or tomorrow (I hope).

I'm a little bit late. I had problems with my 64-bit box during weekend.
I have installed pgsql and unixODBC now. I hope I finish this work today.

> Thanks - I should add that I'm not sure how to deal with the other ones.
> I think it needs someone far more experienced in 32/64 bit issues than
> me to think about it.

I take a look on it but I think I'm less experienced in C and I have no
experience with 32/64 bit issue.

Regards,

Luf

> I'm a little bit late. I had problems with my 64-bit box during weekend.
> I have installed pgsql and unixODBC now. I hope I finish this work today.

I have problem with auto* tools to create configure :-(

I have x86_64 CentOS 4.2 with all updates. auto* versions:
aclocal (GNU automake) 1.9.2
libtoolize (GNU libtool) 1.5.6
autoconf (GNU Autoconf) 2.59
autoheader (GNU Autoconf) 2.59
automake (GNU automake) 1.9.2

I have installed rpms:
postgresql-8.1.2
postgresql-server
postgresql-libs
postgresql-devel
postgresql-pl

configure.ac:10: error: possibly undefined macro: AC_DEFINE
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:18: error: possibly undefined macro: AC_CHECK_LIB
configure.ac:19: error: possibly undefined macro: AC_MSG_ERROR
configure.ac:66: error: possibly undefined macro: AC_CHECK_FUNCS
configure.ac:85: error: possibly undefined macro: AC_TRY_COMPILE

Do I need whole postgresql source code? I try give to aclocal rpm build
dir witoccess.
Any ideas?

Luf

> The attached patch cleans up the 64 bit compiler warnings in
> odbcapi30.c.

I test it and add more warning cleanups. I include your patch into
attached one. I tried it a little bit on 64-bit and 32-bit box.

I don't solve the problem in options.c where 64-bit pointer may
be passwd throught 32-bit number. I don't know how to solve it.

Please review and comment.

Regards,

Luf