Re: Escape patch applied

Lists: pgsql-patches
From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Escape patch applied
Date: 2005-06-26 03:24:02
Message-ID: 200506260324.j5Q3O2Y09878@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

I have applied the E'' escape patch to CVS head.

I am attaching a smaller version that doesn't have the
escape_string_warning GUC and none of the adjustments to our code to use
E''.

I am thinking I should apply this to 8.0.X and 7.4.X? OK? Earlier
versions?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 5.9 KB
From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Escape patch applied
Date: 2005-06-26 12:49:38
Message-ID: 42BEA462.4070704@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Bruce Momjian wrote:

>I have applied the E'' escape patch to CVS head.
>
>

You missed one regression fix: int8-exp-three-digits.out:

================== pgsql.26432/src/test/regress/regression.diffs ===================
*** ./expected/int8-exp-three-digits.out Sun Jun 26 02:04:42 2005
--- ./results/int8.out Sun Jun 26 03:34:16 2005
***************
*** 280,286 ****
| -4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 . 0 0 0
(5 rows)

! SELECT '' AS to_char_16, to_char(q2, '99999 "text" 9999 "9999" 999 "\\"text between quote marks\\"" 9999') FROM INT8_TBL;
to_char_16 | to_char
------------+-----------------------------------------------------------
| text 9999 "text between quote marks" 456
--- 280,286 ----
| -4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 . 0 0 0
(5 rows)

! SELECT '' AS to_char_16, to_char(q2, E'99999 "text" 9999 "9999" 999 "\\"text between quote marks\\"" 9999') FROM INT8_TBL;
to_char_16 | to_char
------------+-----------------------------------------------------------
| text 9999 "text between quote marks" 456

======================================================================

cheers

andrew

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Escape patch applied
Date: 2005-06-27 01:40:07
Message-ID: 200506270140.j5R1e7809492@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Got it. I couldn't find any more.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> >I have applied the E'' escape patch to CVS head.
> >
> >
>
> You missed one regression fix: int8-exp-three-digits.out:
>
> ================== pgsql.26432/src/test/regress/regression.diffs ===================
> *** ./expected/int8-exp-three-digits.out Sun Jun 26 02:04:42 2005
> --- ./results/int8.out Sun Jun 26 03:34:16 2005
> ***************
> *** 280,286 ****
> | -4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 . 0 0 0
> (5 rows)
>
> ! SELECT '' AS to_char_16, to_char(q2, '99999 "text" 9999 "9999" 999 "\\"text between quote marks\\"" 9999') FROM INT8_TBL;
> to_char_16 | to_char
> ------------+-----------------------------------------------------------
> | text 9999 "text between quote marks" 456
> --- 280,286 ----
> | -4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 . 0 0 0
> (5 rows)
>
> ! SELECT '' AS to_char_16, to_char(q2, E'99999 "text" 9999 "9999" 999 "\\"text between quote marks\\"" 9999') FROM INT8_TBL;
> to_char_16 | to_char
> ------------+-----------------------------------------------------------
> | text 9999 "text between quote marks" 456
>
> ======================================================================
>
>
> cheers
>
> andrew
>
>
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073