Lists: | pgsql-patches |
---|
From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Subject: | dbsize backend integration |
Date: | 2005-06-01 18:58:35 |
Message-ID: | 429E055B.5020505@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
As a start for a bunch of instrumentation functions that should be
included in the backend as discussed previously, here are the dbsize
functions. The dbsize.c file should go to the usual place,
src/backend/utils/adt.
Regards,
Andreas
Attachment | Content-Type | Size |
---|---|---|
dbsize-backend.patch | text/x-patch | 28.5 KB |
dbsize.c | text/x-csrc | 6.4 KB |
From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: dbsize backend integration |
Date: | 2005-06-15 01:15:31 |
Message-ID: | 200506150115.j5F1FVT09801@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
Andreas Pflug wrote:
> As a start for a bunch of instrumentation functions that should be
> included in the backend as discussed previously, here are the dbsize
> functions. The dbsize.c file should go to the usual place,
> src/backend/utils/adt.
How does this related to /contrib/dbsize? You have moved some
functions, but not recreated others.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: dbsize backend integration |
Date: | 2005-06-15 06:32:28 |
Message-ID: | 42AFCB7C.1010805@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
Bruce Momjian wrote:
> Andreas Pflug wrote:
>
>>As a start for a bunch of instrumentation functions that should be
>>included in the backend as discussed previously, here are the dbsize
>>functions. The dbsize.c file should go to the usual place,
>>src/backend/utils/adt.
>
>
> How does this related to /contrib/dbsize? You have moved some
> functions, but not recreated others.
>
This patch includes only those functions that return the basic values
nobody but the server can provide; all others are some kind of derived
functions, as implemented by some personal needs. They should stay in
contrib, as they all have some limitations (e.g. implementing a subset,
as relation_size which only counts tables, or total_relation_size et al,
which are schema ignorant).
Regards,
Andreas
From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: dbsize backend integration |
Date: | 2005-06-21 18:44:49 |
Message-ID: | 200506211844.j5LIinU07256@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
This version is being removed from the patches queue because it does not
address how to handle existing dbsize functions not moved into the main
server.
---------------------------------------------------------------------------
Andreas Pflug wrote:
> As a start for a bunch of instrumentation functions that should be
> included in the backend as discussed previously, here are the dbsize
> functions. The dbsize.c file should go to the usual place,
> src/backend/utils/adt.
>
> Regards,
> Andreas
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From: | "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: dbsize backend integration |
Date: | 2005-06-21 19:13:11 |
Message-ID: | 20050621161155.K993@ganymede.hub.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
If dbsize is being moved from contrib to the backend, it should be moved
in in its entirety ...
On Tue, 21 Jun 2005, Bruce Momjian wrote:
>
> This version is being removed from the patches queue because it does not
> address how to handle existing dbsize functions not moved into the main
> server.
>
>
> ---------------------------------------------------------------------------
>
> Andreas Pflug wrote:
>> As a start for a bunch of instrumentation functions that should be
>> included in the backend as discussed previously, here are the dbsize
>> functions. The dbsize.c file should go to the usual place,
>> src/backend/utils/adt.
>>
>> Regards,
>> Andreas
>>
>
>
>
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 5: Have you checked our extensive FAQ?
>>
>> http://www.postgresql.org/docs/faq
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email: scrappy(at)hub(dot)org Yahoo!: yscrappy ICQ: 7615664