HeapTupleSatisfiesUpdate result as enum

Lists: pgsql-patches
From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: pgsql-patches(at)postgresql(dot)org
Subject: HeapTupleSatisfiesUpdate result as enum
Date: 2005-03-19 06:07:42
Message-ID: 20050319060742.GA28818@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Hackers,

Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
enum, like they are for HeapTupleSatisfiesVacuum?

I tried and came up with this patch. If there are no objections, please
apply.

--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
"El día que dejes de cambiar dejarás de vivir"

Attachment Content-Type Size
htsu-cleanup.patch text/plain 10.5 KB
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: HeapTupleSatisfiesUpdate result as enum
Date: 2005-03-19 16:17:07
Message-ID: 15852.1111249027@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
> enum, like they are for HeapTupleSatisfiesVacuum?

History only (the enum result convention for HeapTupleSatisfiesVacuum is
much younger code, IIRC). Seems like a reasonable change to me.

regards, tom lane

From: Neil Conway <neilc(at)samurai(dot)com>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: HeapTupleSatisfiesUpdate result as enum
Date: 2005-03-20 23:40:49
Message-ID: 423E0A01.1020407@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Alvaro Herrera wrote:
> Is there any reason why HeapTupleSatisfiesUpdate return codes are not an
> enum, like they are for HeapTupleSatisfiesVacuum?

Applied, thanks.

-Neil