| Lists: | pgsql-patches |
|---|
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | snprintf improvements |
| Date: | 2005-03-02 14:48:07 |
| Message-ID: | 200503021448.j22Em7p28519@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
This patch uses our own snprintf() only when NLS support is enabled, and
I added support for %qd and %I64d in snprintf. We might need those in
the final version if it is exported to apps.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 2.8 KB |
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: snprintf improvements |
| Date: | 2005-03-02 15:07:43 |
| Message-ID: | 200503021607.44374.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Am Mittwoch, 2. März 2005 15:48 schrieb Bruce Momjian:
> This patch uses our own snprintf() only when NLS support is enabled, and
> I added support for %qd and %I64d in snprintf. We might need those in
> the final version if it is exported to apps.
test -a is not portable.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: snprintf improvements |
| Date: | 2005-03-02 15:43:01 |
| Message-ID: | 200503021543.j22Fh1Y24115@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Peter Eisentraut wrote:
> Am Mittwoch, 2. M?rz 2005 15:48 schrieb Bruce Momjian:
> > This patch uses our own snprintf() only when NLS support is enabled, and
> > I added support for %qd and %I64d in snprintf. We might need those in
> > the final version if it is exported to apps.
>
> test -a is not portable.
Thanks, fixed:
if test "$enable_nls" = yes && test $pgac_need_repl_snprintf = no; then
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: snprintf improvements |
| Date: | 2005-03-02 19:18:40 |
| Message-ID: | 12735.1109791120@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> This patch uses our own snprintf() only when NLS support is enabled,
I see no point in this; it does not solve any problem we need solved,
only complicate the configuration behavior even more.
> I added support for %qd and %I64d in snprintf.
I consider this an awful idea as well.
regards, tom lane
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: snprintf improvements |
| Date: | 2005-03-02 19:35:12 |
| Message-ID: | 200503022035.13379.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This patch uses our own snprintf() only when NLS support is
> > enabled,
>
> I see no point in this; it does not solve any problem we need solved,
> only complicate the configuration behavior even more.
I think this is analogous to checking for snprintf() support of 64-bit
integers only if we previously found 64-bit integers to be supported.
We don't need to include our own snprintf() if we don't need the extra
features it provides.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: snprintf improvements |
| Date: | 2005-03-02 23:57:55 |
| Message-ID: | 200503022357.j22Nvt327502@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This patch uses our own snprintf() only when NLS support is enabled,
>
> I see no point in this; it does not solve any problem we need solved,
> only complicate the configuration behavior even more.
Peter answered this.
> > I added support for %qd and %I64d in snprintf.
>
> I consider this an awful idea as well.
Moved into a NOT_USED block so we can keep it in case we want it later.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073