Re: win32 fixes

Lists: pgsql-patches
From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: win32 fixes
Date: 2004-04-13 06:17:03
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F3F4@harris.memetrics.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


For application to HEAD, following community review.

* Most changes are to fix warnings issued when compiling win32
* removed a few redundant defines
* get_user_name safe under win32
* rationalized pipe read EINTR for win32
* changed all backend instances of sleep() to pg_usleep
- except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a
32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is
acceptable, please replace with pg_usleep(2000000000L)]

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Attachment Content-Type Size
diff.patch application/octet-stream 23.1 KB

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32 fixes
Date: 2004-04-14 20:59:58
Message-ID: 200404142059.i3EKxwZ21770@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


New version of this patch has been added to the PostgreSQL unapplied
patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Claudio Natoli wrote:
>
> For application to HEAD, following community review.
>
> * Most changes are to fix warnings issued when compiling win32
> * removed a few redundant defines
> * get_user_name safe under win32
> * rationalized pipe read EINTR for win32
> * changed all backend instances of sleep() to pg_usleep
> - except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a
> 32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is
> acceptable, please replace with pg_usleep(2000000000L)]
>
>
>
>
>
>
> ---
> Certain disclaimers and policies apply to all email sent from Memetrics.
> For the full text of these disclaimers and policies see
> <a
> href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
> ailpolicy.html</a>
>
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073


From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32 fixes
Date: 2004-04-19 17:42:51
Message-ID: 200404191742.i3JHgpO01092@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Newest version of patch applied. Thanks.

---------------------------------------------------------------------------

Claudio Natoli wrote:
>
> For application to HEAD, following community review.
>
> * Most changes are to fix warnings issued when compiling win32
> * removed a few redundant defines
> * get_user_name safe under win32
> * rationalized pipe read EINTR for win32
> * changed all backend instances of sleep() to pg_usleep
> - except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a
> 32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is
> acceptable, please replace with pg_usleep(2000000000L)]
>
>
>
>
>
>
> ---
> Certain disclaimers and policies apply to all email sent from Memetrics.
> For the full text of these disclaimers and policies see
> <a
> href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
> ailpolicy.html</a>
>
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073