Lists: | pgsql-hackers-win32pgsql-patches |
---|
From: | "Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr> |
---|---|
To: | <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | xlog.c timezone name size |
Date: | 2004-03-15 19:02:17 |
Message-ID: | 002a01c40ac0$09db92c0$0b00a8c0@paolo.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers-win32 pgsql-patches |
On multibyte language locale environment of win32, size of %Z of localtime() function is bigger more then 12 bytes.
so, I suggest that change str_time() function in src/backend/access/transam/xlog.c (2765 line)
buf char array size must be at least 70 bytes (20 bytes = datetime, 50 bytes = tzname of depended local locale(?))
Current str_time() function do not return new line on korean language win32 environment.
It's same on CJK.
From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | "Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr> |
Cc: | pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: xlog.c timezone name size |
Date: | 2004-03-22 04:17:36 |
Message-ID: | 200403220417.i2M4HaZ26598@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers-win32 pgsql-patches |
I have increased the str_time() static variable length to 128. Thanks.
---------------------------------------------------------------------------
Korea PostgreSQL Users' Group wrote:
> On multibyte language locale environment of win32, size of %Z of localtime() function is bigger more then 12 bytes.
>
> so, I suggest that change str_time() function in src/backend/access/transam/xlog.c (2765 line)
>
> buf char array size must be at least 70 bytes (20 bytes = datetime, 50 bytes = tzname of depended local locale(?))
>
> Current str_time() function do not return new line on korean language win32 environment.
> It's same on CJK.
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073