domain check constraint syntax problem for 7.4

They work the same as table constraints with in-line declaration (no
comma).

On Sun, 2003-01-26 at 00:09, Bruno Wolff III wrote:
> I am trying to create a domain with more than one check constraint and
> I am getting an error that I don't think is correct according to the
> documentation. I am not sure if this is a limitation of a partially
> implemented feature or a bug that has so far been overlooked.
>
> For example:
> area=# create domain test6 as int constraint ack check(value<4);
> CREATE DOMAIN
> area=# create domain test7 as int constraint ack check(value<4),
> area-# constraint ack1 check(value>0);
> ERROR: parser: syntax error at or near "," at character 57
> area=# create domain test7 as int check(value<4), check(value>0);
> ERROR: parser: syntax error at or near "," at character 42
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
--
Rod Taylor <rbt(at)rbt(dot)ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

I am trying to create a domain with more than one check constraint and
I am getting an error that I don't think is correct according to the
documentation. I am not sure if this is a limitation of a partially
implemented feature or a bug that has so far been overlooked.

For example:
area=# create domain test6 as int constraint ack check(value<4);
CREATE DOMAIN
area=# create domain test7 as int constraint ack check(value<4),
area-# constraint ack1 check(value>0);
ERROR: parser: syntax error at or near "," at character 57
area=# create domain test7 as int check(value<4), check(value>0);
ERROR: parser: syntax error at or near "," at character 42

On Sun, Jan 26, 2003 at 00:01:04 -0500,
Rod Taylor <rbt(at)rbt(dot)ca> wrote:
> They work the same as table constraints with in-line declaration (no
> comma).

OK. But the documentation implies there is a comma, so it should probably
get chenged then.

This is from the create domain documentation:
CREATE DOMAIN domainname [AS] data_type
[ DEFAULT default_expr ]
[ constraint [, ... ] ]

I would have expected the last line to be:
[ constraint [ ... ] ]
if there weren't supposed to be commas.

Thanks for the help.

On Sun, 2003-01-26 at 00:17, Bruno Wolff III wrote:
> On Sun, Jan 26, 2003 at 00:01:04 -0500,
> Rod Taylor <rbt(at)rbt(dot)ca> wrote:
> > They work the same as table constraints with in-line declaration (no
> > comma).
>
> OK. But the documentation implies there is a comma, so it should probably
> get chenged then.

Yes, it should. (attached)
--
Rod Taylor <rbt(at)rbt(dot)ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.
> On Sun, 2003-01-26 at 00:17, Bruno Wolff III wrote:
> > On Sun, Jan 26, 2003 at 00:01:04 -0500,
> > Rod Taylor <rbt(at)rbt(dot)ca> wrote:
> > > They work the same as table constraints with in-line declaration (no
> > > comma).
> >
> > OK. But the documentation implies there is a comma, so it should probably
> > get chenged then.
>
> Yes, it should. (attached)
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Patch applied to HEAD and 7.3.X. Thanks.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.
> On Sun, 2003-01-26 at 00:17, Bruno Wolff III wrote:
> > On Sun, Jan 26, 2003 at 00:01:04 -0500,
> > Rod Taylor <rbt(at)rbt(dot)ca> wrote:
> > > They work the same as table constraints with in-line declaration (no
> > > comma).
> >
> > OK. But the documentation implies there is a comma, so it should probably
> > get chenged then.
>
> Yes, it should. (attached)
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073