geometry test failed (beta5 on Debian)

Lists: pgsql-hackerspgsql-patches
From: am(at)fx(dot)ro
To: pgsql-hackers(at)postgresql(dot)org
Subject: geometry test failed (beta5 on Debian)
Date: 2002-11-12 01:20:52
Message-ID: 20021112032052.A19615@coto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches


Hi all!

PostgreSQL 7.3 beta5
Debian GNU/Linux 2.2r5 ( x86 )
.............

All regression tests passed, except geometry.
The differences don't seem to be big. I think the test can be
validated, but i'm not absolutely sure. So i've attached the diff.

.............

On the other hand, in psql , tab-completion doesn't seem to
work for certain commands :

ALTER DATABASE ; ALTER TRIGGER ; CHECKPOINT ; CREATE CAST ;
CREATE CONSTRAINT TRIGGER ; CREATE CONVERSION ; CREATE DOMAIN ;
CREATE LANGUAGE ; DEALLOCATE ; DROP CAST ; DROP CONVERSION ;
DROP DOMAIN ; DROP LANGUAGE ; EXECUTE ; PREPARE

( this could be considered a low priority todo item , though )
.............

Regards,

Adrian Maier
(am(at)fx(dot)ro)


From: am(at)fx(dot)ro
To: pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: geometry test failed (beta5 on Debian)
Date: 2002-11-12 01:26:40
Message-ID: 20021112032640.A19659@coto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

On Tue, Nov 12, 2002 at 03:20:52AM +0200, am(at)fx(dot)ro wrote:
> validated, but i'm not absolutely sure. So i've attached the diff.

Oops , forgot to attach it in the first message.
This is the diff.

Attachment Content-Type Size
regression.diffs text/plain 10.2 KB

From: Rod Taylor <rbt(at)rbt(dot)ca>
To: am(at)fx(dot)ro
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: psql tab completion
Date: 2002-11-12 04:40:12
Message-ID: 1037076013.66615.11.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Clean up psql:

Add simple ALTER DATABASE, ALTER TRIGGER, CHECK POINT, CREATE
CONVERSION, CREATE DOMAIN, CREATE LANGUAGE, DEALLOCATE, DROP CONVERSION,
DROP DOMAIN, DROP LANGUAGE, EXECUTE, PREPARE

Complete CAST in CREATE CAST and DROP CAST but doesn't suggest what
should follow.

Add many more SET / SHOW variables to the list. Taken from SHOW ALL
output.

Complete a case sensitive search to allow \dD, \dd, \dS, \ds, \h, \H to
complete properly. But there are no matches, then try a case
insensitive search to allow case conversion. Add all missing help
options.

\Q<tab> -> \q
\dD<tab> -> \dD
\dd<tab> -> \dd
\D<tab><tab><tab> -> \d (with listing of \d? commands)
sel<tab> -> SELECT

> On the other hand, in psql , tab-completion doesn't seem to
> work for certain commands :
>
> ALTER DATABASE ; ALTER TRIGGER ; CHECKPOINT ; CREATE CAST ;
> CREATE CONSTRAINT TRIGGER ; CREATE CONVERSION ; CREATE DOMAIN ;
> CREATE LANGUAGE ; DEALLOCATE ; DROP CAST ; DROP CONVERSION ;
> DROP DOMAIN ; DROP LANGUAGE ; EXECUTE ; PREPARE
>
> ( this could be considered a low priority todo item , though )

--
Rod Taylor

Attachment Content-Type Size
psql.patch text/plain 9.8 KB

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)rbt(dot)ca>
Cc: am(at)fx(dot)ro, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql tab completion
Date: 2002-11-13 03:15:52
Message-ID: 200211130315.gAD3Fqa21140@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Rod Taylor wrote:
> Clean up psql:
>
> Add simple ALTER DATABASE, ALTER TRIGGER, CHECK POINT, CREATE
> CONVERSION, CREATE DOMAIN, CREATE LANGUAGE, DEALLOCATE, DROP CONVERSION,
> DROP DOMAIN, DROP LANGUAGE, EXECUTE, PREPARE
>
> Complete CAST in CREATE CAST and DROP CAST but doesn't suggest what
> should follow.
>
> Add many more SET / SHOW variables to the list. Taken from SHOW ALL
> output.
>
> Complete a case sensitive search to allow \dD, \dd, \dS, \ds, \h, \H to
> complete properly. But there are no matches, then try a case
> insensitive search to allow case conversion. Add all missing help
> options.
>
> \Q<tab> -> \q
> \dD<tab> -> \dD
> \dd<tab> -> \dd
> \D<tab><tab><tab> -> \d (with listing of \d? commands)
> sel<tab> -> SELECT
>
>
> > On the other hand, in psql , tab-completion doesn't seem to
> > work for certain commands :
> >
> > ALTER DATABASE ; ALTER TRIGGER ; CHECKPOINT ; CREATE CAST ;
> > CREATE CONSTRAINT TRIGGER ; CREATE CONVERSION ; CREATE DOMAIN ;
> > CREATE LANGUAGE ; DEALLOCATE ; DROP CAST ; DROP CONVERSION ;
> > DROP DOMAIN ; DROP LANGUAGE ; EXECUTE ; PREPARE
> >
> > ( this could be considered a low priority todo item , though )
>
> --
> Rod Taylor

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073


From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)rbt(dot)ca>
Cc: am(at)fx(dot)ro, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: psql tab completion
Date: 2002-11-15 03:08:01
Message-ID: 200211150308.gAF381H25809@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches


Nice comprehensive patch applied. Thanks.

---------------------------------------------------------------------------

Rod Taylor wrote:
> Clean up psql:
>
> Add simple ALTER DATABASE, ALTER TRIGGER, CHECK POINT, CREATE
> CONVERSION, CREATE DOMAIN, CREATE LANGUAGE, DEALLOCATE, DROP CONVERSION,
> DROP DOMAIN, DROP LANGUAGE, EXECUTE, PREPARE
>
> Complete CAST in CREATE CAST and DROP CAST but doesn't suggest what
> should follow.
>
> Add many more SET / SHOW variables to the list. Taken from SHOW ALL
> output.
>
> Complete a case sensitive search to allow \dD, \dd, \dS, \ds, \h, \H to
> complete properly. But there are no matches, then try a case
> insensitive search to allow case conversion. Add all missing help
> options.
>
> \Q<tab> -> \q
> \dD<tab> -> \dD
> \dd<tab> -> \dd
> \D<tab><tab><tab> -> \d (with listing of \d? commands)
> sel<tab> -> SELECT
>
>
> > On the other hand, in psql , tab-completion doesn't seem to
> > work for certain commands :
> >
> > ALTER DATABASE ; ALTER TRIGGER ; CHECKPOINT ; CREATE CAST ;
> > CREATE CONSTRAINT TRIGGER ; CREATE CONVERSION ; CREATE DOMAIN ;
> > CREATE LANGUAGE ; DEALLOCATE ; DROP CAST ; DROP CONVERSION ;
> > DROP DOMAIN ; DROP LANGUAGE ; EXECUTE ; PREPARE
> >
> > ( this could be considered a low priority todo item , though )
>
> --
> Rod Taylor

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073