Re: pgsql-server/src Makefile.global.in makefiles/ ...

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian(at)postgresql(dot)org 02/11/09 19:37:28

Modified files:
src : Makefile.global.in
src/makefiles : Makefile.unixware

Log message:
I am attaching a patch file that will replace the previous one. It only
contains the patches to Makefile.global.in and Makefile.unixware. The
Makefile.unixware patch has been updated to include the contents of
LD_LIBRARY_PATH, if present, to the -rpath (-R) option. This change
will simplify configuring and building PostgreSQL on systems that
support LD_LIBRARY_PATH. You can set LD_LIBRARY_PATH to include all
the directorys you want to have searched for additional libraries, run
configure, then run make. The paths in LD_LIBRARY_PATH will then be
embedded in the executables via the -rpath (-R) option to the linker,
and so will not require LD_LIBRARY_PATH in order to run.

Billy G. Allie

I still object to this patch, because it introduces platform-specific
behavior that is inconsistent with all other platforms.

Bruce Momjian - CVS writes:

> CVSROOT: /cvsroot
> Module name: pgsql-server
> Changes by: momjian(at)postgresql(dot)org 02/11/09 19:37:28
>
> Modified files:
> src : Makefile.global.in
> src/makefiles : Makefile.unixware
>
> Log message:
> I am attaching a patch file that will replace the previous one. It only
> contains the patches to Makefile.global.in and Makefile.unixware. The
> Makefile.unixware patch has been updated to include the contents of
> LD_LIBRARY_PATH, if present, to the -rpath (-R) option. This change
> will simplify configuring and building PostgreSQL on systems that
> support LD_LIBRARY_PATH. You can set LD_LIBRARY_PATH to include all
> the directorys you want to have searched for additional libraries, run
> configure, then run make. The paths in LD_LIBRARY_PATH will then be
> embedded in the executables via the -rpath (-R) option to the linker,
> and so will not require LD_LIBRARY_PATH in order to run.
>
> Billy G. Allie
>
>

--
Peter Eisentraut peter_e(at)gmx(dot)net

OK, how do we proceed? If we back it out, how does Billy get this
working for his system?

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> I still object to this patch, because it introduces platform-specific
> behavior that is inconsistent with all other platforms.
>
> Bruce Momjian - CVS writes:
>
> > CVSROOT: /cvsroot
> > Module name: pgsql-server
> > Changes by: momjian(at)postgresql(dot)org 02/11/09 19:37:28
> >
> > Modified files:
> > src : Makefile.global.in
> > src/makefiles : Makefile.unixware
> >
> > Log message:
> > I am attaching a patch file that will replace the previous one. It only
> > contains the patches to Makefile.global.in and Makefile.unixware. The
> > Makefile.unixware patch has been updated to include the contents of
> > LD_LIBRARY_PATH, if present, to the -rpath (-R) option. This change
> > will simplify configuring and building PostgreSQL on systems that
> > support LD_LIBRARY_PATH. You can set LD_LIBRARY_PATH to include all
> > the directorys you want to have searched for additional libraries, run
> > configure, then run make. The paths in LD_LIBRARY_PATH will then be
> > embedded in the executables via the -rpath (-R) option to the linker,
> > and so will not require LD_LIBRARY_PATH in order to run.
> >
> > Billy G. Allie
> >
> >
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Bruce Momjian writes:

> OK, how do we proceed?

To be honest, I haven't even seen the patch yet, only a description. I
can't find the actual patch in my local mailboxes or in the archives on
the web. The idea sounds right and it should be expanded to all
platforms, but it needs to be considered carefully. Rpaths are awfully
messy.

> If we back it out, how does Billy get this working for his system?

The same way everybody else does.

--
Peter Eisentraut peter_e(at)gmx(dot)net

OK, Peter, here is Billie's patch.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > OK, how do we proceed?
>
> To be honest, I haven't even seen the patch yet, only a description. I
> can't find the actual patch in my local mailboxes or in the archives on
> the web. The idea sounds right and it should be expanded to all
> platforms, but it needs to be considered carefully. Rpaths are awfully
> messy.
>
> > If we back it out, how does Billy get this working for his system?
>
> The same way everybody else does.
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

This patch needs to be reverted. It causes the compilation environment
seen by the makefiles to be different from what is dealt with in
configure, which creates a recipe for desaster. If additional "rpaths"
are to be added to the linker flags, it needs to be done in configure
before any tests that invoke the linker.

As a side note, I would even question that the patch as it stands is
generally useful: Consider the case that one has libraries in the
non-standard directories that are now covered by the additional rpath
flags. How could configure even produce reliable results if it doesn't
have access to those presumably relevant libraries?

Bruce Momjian writes:

>
> OK, Peter, here is Billie's patch.
>
> ---------------------------------------------------------------------------
>
> Peter Eisentraut wrote:
> > Bruce Momjian writes:
> >
> > > OK, how do we proceed?
> >
> > To be honest, I haven't even seen the patch yet, only a description. I
> > can't find the actual patch in my local mailboxes or in the archives on
> > the web. The idea sounds right and it should be expanded to all
> > platforms, but it needs to be considered carefully. Rpaths are awfully
> > messy.
> >
> > > If we back it out, how does Billy get this working for his system?
> >
> > The same way everybody else does.
> >
> > --
> > Peter Eisentraut peter_e(at)gmx(dot)net
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> >
>
>

--
Peter Eisentraut peter_e(at)gmx(dot)net

OK, feel free to revert it. It seems what Billie needs to do is a
reasonable thing, and I think you wanted to make it more generic rather
than port specific --- go ahead.

Billie, we will try to keep you on this as a CC so you can see how it
will be merged into the configure process.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> This patch needs to be reverted. It causes the compilation environment
> seen by the makefiles to be different from what is dealt with in
> configure, which creates a recipe for desaster. If additional "rpaths"
> are to be added to the linker flags, it needs to be done in configure
> before any tests that invoke the linker.
>
> As a side note, I would even question that the patch as it stands is
> generally useful: Consider the case that one has libraries in the
> non-standard directories that are now covered by the additional rpath
> flags. How could configure even produce reliable results if it doesn't
> have access to those presumably relevant libraries?
>
> Bruce Momjian writes:
>
> >
> > OK, Peter, here is Billie's patch.
> >
> > ---------------------------------------------------------------------------
> >
> > Peter Eisentraut wrote:
> > > Bruce Momjian writes:
> > >
> > > > OK, how do we proceed?
> > >
> > > To be honest, I haven't even seen the patch yet, only a description. I
> > > can't find the actual patch in my local mailboxes or in the archives on
> > > the web. The idea sounds right and it should be expanded to all
> > > platforms, but it needs to be considered carefully. Rpaths are awfully
> > > messy.
> > >
> > > > If we back it out, how does Billy get this working for his system?
> > >
> > > The same way everybody else does.
> > >
> > > --
> > > Peter Eisentraut peter_e(at)gmx(dot)net
> > >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 2: you can get off all lists at once with the unregister command
> > > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> > >
> >
> >
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073