Re: Fix for 2 test cases of JDBC test suite

Attached is a patch that fixes 2 test cases of the JDBC test
suite. This reduces the number of failures from 9 to 7.

Both ConnectionTest and JBuilderTest did not create their own
tables, which caused these test cases to fail with "relation ...
does not exist". It appears these test cases relied on tables
created by the example code elsewhere in the source tree. I've
added the necessary "create table" and "drop table" statements
to the test cases, using the column definitions from the example
code.

While working on that I modified the helper method createTable
in JDBC2Tests.java to take a table parameter, rather than using
table names passed via the properties in build.xml. I'm not sure
what that was good for, and in fact, except for the default
table name "jdbctest", this functionality wasn't used at all.

Regards,
René Pijlman <rene(at)lab(dot)applinet(dot)nl>

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> Attached is a patch that fixes 2 test cases of the JDBC test
> suite. This reduces the number of failures from 9 to 7.
>
> Both ConnectionTest and JBuilderTest did not create their own
> tables, which caused these test cases to fail with "relation ...
> does not exist". It appears these test cases relied on tables
> created by the example code elsewhere in the source tree. I've
> added the necessary "create table" and "drop table" statements
> to the test cases, using the column definitions from the example
> code.
>
> While working on that I modified the helper method createTable
> in JDBC2Tests.java to take a table parameter, rather than using
> table names passed via the properties in build.xml. I'm not sure
> what that was good for, and in fact, except for the default
> table name "jdbctest", this functionality wasn't used at all.
>
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Patch applied. Thanks.

> Attached is a patch that fixes 2 test cases of the JDBC test
> suite. This reduces the number of failures from 9 to 7.
>
> Both ConnectionTest and JBuilderTest did not create their own
> tables, which caused these test cases to fail with "relation ...
> does not exist". It appears these test cases relied on tables
> created by the example code elsewhere in the source tree. I've
> added the necessary "create table" and "drop table" statements
> to the test cases, using the column definitions from the example
> code.
>
> While working on that I modified the helper method createTable
> in JDBC2Tests.java to take a table parameter, rather than using
> table names passed via the properties in build.xml. I'm not sure
> what that was good for, and in fact, except for the default
> table name "jdbctest", this functionality wasn't used at all.
>
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026