| Lists: | pgsql-hackers |
|---|
| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Question about change in page/tuple header (v4) |
| Date: | 2007-08-14 12:18:25 |
| Message-ID: | 46C19D91.3020100@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I'm comparing now different version of page layer, and I have two questions:
1) We now store only low 16bits TLI, but name in structure stays same.
Maybe pg_tli_lo could be better.
2) HASOID has been moved in infomask and original place is unused. Is
there some reason for that? This change little bit complicate tuple
header upgrade. If there is not real reason to have it in current place,
I recommend to move it back.
thanks Zdenek
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Question about change in page/tuple header (v4) |
| Date: | 2007-08-14 14:26:24 |
| Message-ID: | 19168.1187101584@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> 2) HASOID has been moved in infomask and original place is unused. Is
> there some reason for that?
To keep it next to the other bits that are about tuple content rather
than transactional behavior.
> This change little bit complicate tuple
> header upgrade. If there is not real reason to have it in current place,
> I recommend to move it back.
There are enough other changes there that you're going to have to
manipulate the infomask anyway.
regards, tom lane