Re: pgsql/src backend/parser/gram.y backend/utils/ ...

CVSROOT: /cvsroot
Module name: pgsql
Changes by: momjian(at)postgresql(dot)org 02/06/17 03:00:27

Modified files:
src/backend/parser: gram.y
src/backend/utils/adt: mac.c
src/test/regress/data: agg.data constrf.data constro.data
desc.data emp.data hash.data onek.data
person.data real_city.data rect.data
streets.data stud_emp.data student.data
tenk.data

Log message:
Merge ALTER GROUP ADD/DROP rules by creating add_drop action.

Brice - this commit seems to have broken the regression tests:

chriskl(at)alpha:~/pgsql-head/src/test/regress/data$ ls -al
total 4
drwxr-xr-x 3 chriskl users 512 Jun 17 16:01 .
drwxr-xr-x 12 chriskl users 512 Jun 13 12:22 ..
drwxr-xr-x 2 chriskl users 512 Jun 17 16:01 CVS
-rw-r--r-- 1 chriskl users 0 Jun 17 16:00 agg.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 constrf.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 constro.data
-rw-r--r-- 1 chriskl users 20 Jul 9 1996 dept.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 desc.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 emp.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 hash.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 onek.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 person.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 real_city.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 rect.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 streets.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 stud_emp.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 student.data
-rw-r--r-- 1 chriskl users 0 Jun 17 16:01 tenk.data

You have emptied all the data files!!!

Chris

> -----Original Message-----
> From: pgsql-committers-owner(at)postgresql(dot)org
> [mailto:pgsql-committers-owner(at)postgresql(dot)org]On Behalf Of Bruce Momjian
> - CVS
> Sent: Monday, 17 June 2002 3:00 PM
> To: pgsql-committers(at)postgresql(dot)org
> Subject: [COMMITTERS] pgsql/src backend/parser/gram.y backend/utils/ ...
>
>
> CVSROOT: /cvsroot
> Module name: pgsql
> Changes by: momjian(at)postgresql(dot)org 02/06/17 03:00:27
>
> Modified files:
> src/backend/parser: gram.y
> src/backend/utils/adt: mac.c
> src/test/regress/data: agg.data constrf.data constro.data
> desc.data emp.data hash.data onek.data
> person.data real_city.data rect.data
> streets.data stud_emp.data student.data
> tenk.data
>
> Log message:
> Merge ALTER GROUP ADD/DROP rules by creating add_drop action.
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

momjian(at)postgresql(dot)org (Bruce Momjian - CVS) writes:
> Modified files:
> src/backend/parser: gram.y
> src/backend/utils/adt: mac.c
> src/test/regress/data: agg.data constrf.data constro.data
> desc.data emp.data hash.data onek.data
> person.data real_city.data rect.data
> streets.data stud_emp.data student.data
> tenk.data
> Log message:
> Merge ALTER GROUP ADD/DROP rules by creating add_drop action.

You want to explain why this commit changed the regression tests?
Or mac.c?

regards, tom lane

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian - CVS) writes:
> > Modified files:
> > src/backend/parser: gram.y
> > src/backend/utils/adt: mac.c
> > src/test/regress/data: agg.data constrf.data constro.data
> > desc.data emp.data hash.data onek.data
> > person.data real_city.data rect.data
> > streets.data stud_emp.data student.data
> > tenk.data
> > Log message:
> > Merge ALTER GROUP ADD/DROP rules by creating add_drop action.
>
> You want to explain why this commit changed the regression tests?

CVS corruption. Bizarre.

> Or mac.c?

The mac.c change was related to my testing if the recent mac.c change
somehow was causing this. Re-added now. I had run regression after
those patches anyway, but I tested just to make sure.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026