| Lists: | pgsql-hackers |
|---|
| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Oddly indented raw_expression_tree_walker |
| Date: | 2010-04-08 05:38:45 |
| Message-ID: | 20100408143844.95FA.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD.
I expected pgindent would fix those clutter, but it could not.
Should we cleanup it manually, or leave it as-is?
Also, should we backport such kind of cleanups to previous releases?
Index: src/backend/nodes/nodeFuncs.c
===================================================================
@@ -2198,7 +2198,7 @@
* that could appear under it, but not other statement types.
*/
bool
- raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
+raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
{
ListCell *temp;
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Oddly indented raw_expression_tree_walker |
| Date: | 2010-04-08 08:53:40 |
| Message-ID: | 17217.1270716820@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD.
> I expected pgindent would fix those clutter, but it could not.
> Should we cleanup it manually, or leave it as-is?
There is exactly zero point in a manual cleanup, because pgindent will
just do it again next time. If you want to try to fix pgindent,
though, have at it.
regards, tom lane