Lists: | pgsql-hackers |
---|
From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | beta testing - pg_upgrade bug fix - double free |
Date: | 2010-05-22 02:11:34 |
Message-ID: | AANLkTikUK0Ku9Tcwc_9i9GTecd2_dxMEbVyFbPgHpph2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hello
it fixes bug
pg_upgrade(13359) malloc: *** error for object 0x801600:
non-page-aligned, non-allocated pointer being freed
*** set a breakpoint in malloc_error_break to debug
arget 03:31 /usr/local/src/postgresql/contrib/pg_upgrade git diff .
diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 31f12fb..f989229 100644
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char
*sequence_script_file_name)
ctx->new.bindir,
ctx->new.port, sequence_script_file_name,
ctx->logfile);
unlink(sequence_script_file_name);
- pg_free(sequence_script_file_name);
check_ok(ctx);
}
by Jan Matousek
Regards
Pavel
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: beta testing - pg_upgrade bug fix - double free |
Date: | 2010-05-23 03:01:57 |
Message-ID: | AANLkTilXOxfc-M_IGMYae3_rVR03L-u5FUFBQWHGkNHo@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Fri, May 21, 2010 at 10:11 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> it fixes bug
>
> pg_upgrade(13359) malloc: *** error for object 0x801600:
> non-page-aligned, non-allocated pointer being freed
> *** set a breakpoint in malloc_error_break to debug
>
>
> arget 03:31 /usr/local/src/postgresql/contrib/pg_upgrade git diff .
> diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
> index 31f12fb..f989229 100644
> --- a/contrib/pg_upgrade/check.c
> +++ b/contrib/pg_upgrade/check.c
> @@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char
> *sequence_script_file_name)
> ctx->new.bindir,
> ctx->new.port, sequence_script_file_name,
> ctx->logfile);
> unlink(sequence_script_file_name);
> - pg_free(sequence_script_file_name);
> check_ok(ctx);
> }
>
> by Jan Matousek
This patch looks correct to me, although I haven't had a chance to test it yet.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: beta testing - pg_upgrade bug fix - double free |
Date: | 2010-05-23 16:54:49 |
Message-ID: | 17198.1274633689@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> --- a/contrib/pg_upgrade/check.c
> +++ b/contrib/pg_upgrade/check.c
> @@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char
> *sequence_script_file_name)
> ctx->new.bindir,
> ctx->new.port, sequence_script_file_name,
> ctx->logfile);
> unlink(sequence_script_file_name);
> - pg_free(sequence_script_file_name);
> check_ok(ctx);
> }
Done, thanks.
regards, tom lane
From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: beta testing - pg_upgrade bug fix - double free |
Date: | 2010-05-24 17:45:01 |
Message-ID: | 201005241745.o4OHj1728538@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Pavel Stehule wrote:
> Hello
>
> it fixes bug
>
> pg_upgrade(13359) malloc: *** error for object 0x801600:
> non-page-aligned, non-allocated pointer being freed
> *** set a breakpoint in malloc_error_break to debug
>
>
> arget 03:31 /usr/local/src/postgresql/contrib/pg_upgrade git diff .
> diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
> index 31f12fb..f989229 100644
> --- a/contrib/pg_upgrade/check.c
> +++ b/contrib/pg_upgrade/check.c
> @@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char
> *sequence_script_file_name)
> ctx->new.bindir,
> ctx->new.port, sequence_script_file_name,
> ctx->logfile);
> unlink(sequence_script_file_name);
> - pg_free(sequence_script_file_name);
> check_ok(ctx);
> }
Thanks for the report. Tom has applied your fix.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com