Re: About the new %sdt macro in F-11 package

Lists: pgsql-hackers
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Devrim GÜNDÜZ <devrim(at)gunduz(dot)org>
Cc: pgsql-hackers(at)postgreSQL(dot)org, Mark Wielaard <mjw(at)redhat(dot)com>
Subject: Re: About the new %sdt macro in F-11 package
Date: 2009-03-10 22:57:31
Message-ID: 16461.1236725851@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim(at)gunduz(dot)org> writes:
> I was trying to make a scratch build in Koji for orafce package, and it
> failed:

> http://koji.fedoraproject.org/koji/getfile?taskID=1235602&name=build.log

> I consulted #fedora-devel @ Freenode, and the conclusion was this:

> <walters> devrimgunduz: the devel subpackage needs a Requires:
> systemtap-sdt-devel

> He is talking about postgresql-devel package actually.

The reason this is a problem is that in 8.3, pg_trace.h is included by
c.h, which means that *anything* built against Postgres headers needs
access to the dtrace headers if we configured --enable-dtrace.

As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now
included only by the .c files that actually need it. ISTM that we
should make 8.3 do likewise. Having postgresql-devel drag in
systemtap-sdt-devel would pretty much suck IMHO.

Comments?

regards, tom lane

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)gunduz(dot)org>, pgsql-hackers(at)postgreSQL(dot)org, Mark Wielaard <mjw(at)redhat(dot)com>
Subject: Re: About the new %sdt macro in F-11 package
Date: 2009-03-10 23:07:34
Message-ID: 20090310230734.GH4406@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane wrote:

> As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now
> included only by the .c files that actually need it. ISTM that we
> should make 8.3 do likewise.

Here's a patch for this.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
dtrace-83.patch text/x-diff 2.3 KB
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Devrim GÜNDÜZ <devrim(at)gunduz(dot)org>, pgsql-hackers(at)postgreSQL(dot)org, Mark Wielaard <mjw(at)redhat(dot)com>
Subject: Re: About the new %sdt macro in F-11 package
Date: 2009-03-10 23:49:39
Message-ID: 17117.1236728979@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now
>> included only by the .c files that actually need it. ISTM that we
>> should make 8.3 do likewise.

> Here's a patch for this.

Oh, thanks, I was just about to go off and do that myself, but you
saved me the trouble. Please commit.

regards, tom lane

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Devrim GÜNDÜZ <devrim(at)gunduz(dot)org>, pgsql-hackers(at)postgreSQL(dot)org, Mark Wielaard <mjw(at)redhat(dot)com>
Subject: Re: About the new %sdt macro in F-11 package
Date: 2009-03-11 00:08:44
Message-ID: 20090311000844.GJ4406@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane wrote:
> >> As of CVS HEAD, I see that we got rid of that, and pg_trace.h is now
> >> included only by the .c files that actually need it. ISTM that we
> >> should make 8.3 do likewise.
>
> > Here's a patch for this.
>
> Oh, thanks, I was just about to go off and do that myself, but you
> saved me the trouble. Please commit.

Done.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support