Re: Obsolete functions istrue, isfalse, etc.

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Obsolete functions istrue, isfalse, etc.
Date: 2008-10-04 20:44:16
Message-ID: 48E7D5A0.2020908@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

There are four functions

istrue
isfalse
isnottrue
isnotfalse

defined in bool.c and exported to SQL that are not documented anywhere
and are not part of any spec that I would know of. The release notes
indicate that they were used to implement IS TRUE, IS FALSE, etc. until
PostgreSQL 6.2, so they were internal functions from the very beginning.
Should we remove those now? I suppose there is a slight chance that
10 year old dumps might contain references to them? But it is easy to
reimplement them in user-space should anyone need them.


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Obsolete functions istrue, isfalse, etc.
Date: 2008-10-04 22:39:49
Message-ID: 16904.1223159989@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> istrue
> isfalse
> isnottrue
> isnotfalse

> Should we remove those now? I suppose there is a slight chance that
> 10 year old dumps might contain references to them? But it is easy to
> reimplement them in user-space should anyone need them.

Of course the other side of the coin is that it's not costing us
anything noticeable to leave them there. But I have no strong objection
to removing 'em.

If we are going to get rid of them, I'd say we should also nuke
nullvalue() and nonnullvalue().

regards, tom lane