Re: Japanies translation breaks solaris build

Lists: pgsql-hackers
From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Japanies translation breaks solaris build
Date: 2010-05-14 06:58:23
Message-ID: 1273820303.1825.38.camel@hlipa-nb
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2010-05-13%2021:06:01

msgfmt -o po/ja.mo po/ja.po
WARNING: the string after closing " is ignored at line number 11.
Error, No space after directive at line number 2008.
ERROR: Exiting...
gmake[2]: *** [po/ja.mo] Error 2

The problem is that it contains mix of DOS/Unix end of lines.

Zdenek

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Japanies translation breaks solaris build
Date: 2010-05-14 10:38:38
Message-ID: 20100514193837.A473.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> wrote:

> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2010-05-13%2021:06:01
> The problem is that it contains mix of DOS/Unix end of lines.

I removed two CRs in ja.po.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Japanies translation breaks solaris build
Date: 2010-05-14 13:04:45
Message-ID: 1273842285.1825.127.camel@hlipa-nb
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Takahiro Itagaki píše v pá 14. 05. 2010 v 19:38 +0900:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> wrote:
>
> > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2010-05-13%2021:06:01
> > The problem is that it contains mix of DOS/Unix end of lines.
>
> I removed two CRs in ja.po.

Thanks. Gothic moth is green again

http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=gothic_moth&br=HEAD

The rest solaris machine will recover during a night.

Zdenek

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Japanies translation breaks solaris build
Date: 2010-05-15 05:39:26
Message-ID: 1273901966.5043.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On fre, 2010-05-14 at 15:04 +0200, Zdenek Kotala wrote:
> Takahiro Itagaki píše v pá 14. 05. 2010 v 19:38 +0900:
> > Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> wrote:
> >
> > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2010-05-13%2021:06:01
> > > The problem is that it contains mix of DOS/Unix end of lines.
> >
> > I removed two CRs in ja.po.
>
> Thanks. Gothic moth is green again
>
> http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=gothic_moth&br=HEAD
>
> The rest solaris machine will recover during a night.

I have added a check to the admin scripts to prevent this in the future.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Japanies translation breaks solaris build
Date: 2010-05-15 05:50:00
Message-ID: 15709.1273902600@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On fre, 2010-05-14 at 15:04 +0200, Zdenek Kotala wrote:
>>> The problem is that it contains mix of DOS/Unix end of lines.

> I have added a check to the admin scripts to prevent this in the future.

I wonder if we shouldn't be trying to prevent this at the CVS-checkin
level. We've had problems with people committing DOS-ish newlines
many times before.

regards, tom lane