Re: Useless "reject patterns" in mail lists

I just got a moderation request which said

> The request requires your confirmation for the following reason(s):
>
> GLOBAL ADMIN BODY: /^\s*config\b/i matched " config" at line number 8.

My mail said:

> To: pgsql-committers(at)postgresql(dot)org
> Date: Tue, 11 Dec 2007 20:07:31 +0000 (UTC)
> Subject: pgsql: Make CSV column ordering a bit more logical.
> Message-Id: <20071211200731(dot)C323E7540F0(at)cvs(dot)postgresql(dot)org>
>
> Log Message:
> -----------
> Make CSV column ordering a bit more logical.

In my opinion, this business of holding for moderation messages matching
"^\s*config\b" has bought us no benefit at all, and we should get rid of
it. There are other similar patterns. Can we please fix it?

--
Alvaro Herrera http://www.flickr.com/photos/alvherre/
"In fact, the basic problem with Perl 5's subroutines is that they're not
crufty enough, so the cruft leaks out into user-defined code instead, by
the Conservation of Cruft Principle." (Larry Wall, Apocalypse 6)

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> In my opinion, this business of holding for moderation messages matching
> "^\s*config\b" has bought us no benefit at all, and we should get rid of
> it. There are other similar patterns. Can we please fix it?

Yeah, I've repeatedly had commit messages blocked by that pattern and
some others that didn't seem all that likely to cut noise. Could we
narrow down the patterns, at least for -committers?

regards, tom lane

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

What would you like me to remove from the patterns being checked for:

/^accept$/i
/^reject$/i
/\bcancel\b/i
/\badd me\b/i
/\bdelete me\b/i
/\bremove\s+me\b/i
/\bchange\b.*\baddress\b/
/\bsignoff\b/i
/\bsubscribe\b/i
/^sub\b/i
/\bunsubscribe\b/i
/^unsub\b/i
/^\s*help\s*$/i
/^\s*info\s*$/i
/^\s*info\s+\S+\s*$/i
/^\s*lists\s*$/i
/^\s*which\s*$/i
/^\s*which\s+\S+\s*$/i
/^\s*index\s*$/i
/^\s*index\s+\S+\s*$/i
/^\s*who\s*$/i
/^\s*who\s+\S+\s*$/i
/^\s*get\s+\S+\s*$/i
/^\s*get\s+\S+\s+\S+\s*$/i
/^\s*approve\b/i
/^\s*passwd\b/i
/^\s*newinfo\b/i
/^\s*config\b/i
/^\s*newconfig\b/i
/^\s*writeconfig\b/i
/^\s*mkdigest\b/i

I can do it for only a specific list, or globally ... you tell me ...

- --On Tuesday, December 11, 2007 17:18:04 -0300 Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> I just got a moderation request which said
>
>> The request requires your confirmation for the following reason(s):
>>
>> GLOBAL ADMIN BODY: /^\s*config\b/i matched " config" at line
>> number 8.
>
> My mail said:
>
>> To: pgsql-committers(at)postgresql(dot)org
>> Date: Tue, 11 Dec 2007 20:07:31 +0000 (UTC)
>> Subject: pgsql: Make CSV column ordering a bit more logical.
>> Message-Id: <20071211200731(dot)C323E7540F0(at)cvs(dot)postgresql(dot)org>
>>
>> Log Message:
>> -----------
>> Make CSV column ordering a bit more logical.
>
> In my opinion, this business of holding for moderation messages matching
> "^\s*config\b" has bought us no benefit at all, and we should get rid of
> it. There are other similar patterns. Can we please fix it?
>
> --
> Alvaro Herrera http://www.flickr.com/photos/alvherre/
> "In fact, the basic problem with Perl 5's subroutines is that they're not
> crufty enough, so the cruft leaks out into user-defined code instead, by
> the Conservation of Cruft Principle." (Larry Wall, Apocalypse 6)

- ----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email . scrappy(at)hub(dot)org MSN . scrappy(at)hub(dot)org
Yahoo . yscrappy Skype: hub.org ICQ . 7615664
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFHX0Ig4QvfyHIvDvMRAljxAKCzKZoSYq3Oz3w1i2ux1nl9B5SPZACgxM5O
Ntidnqm1SrHKYX8ebRetBoM=
=2mvn
-----END PGP SIGNATURE-----

Marc G. Fournier wrote:

> What would you like me to remove from the patterns being checked for:

Please remove "config" and "cancel", globally, for the time being.
These reject plenty of valid messages. I can't remember seeing the
rest recently.

--
Alvaro Herrera Valdivia, Chile ICBM: S 39º 49' 18.1", W 73º 13' 56.4"
"Escucha y olvidarás; ve y recordarás; haz y entenderás" (Confucio)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Done

- --On Tuesday, December 11, 2007 23:22:29 -0300 Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> Marc G. Fournier wrote:
>
>> What would you like me to remove from the patterns being checked for:
>
> Please remove "config" and "cancel", globally, for the time being.
> These reject plenty of valid messages. I can't remember seeing the
> rest recently.
>
> --
> Alvaro Herrera Valdivia, Chile ICBM: S 39º 49' 18.1", W 73º 13'
> 56.4" "Escucha y olvidarás; ve y recordarás; haz y entenderás" (Confucio)

- ----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email . scrappy(at)hub(dot)org MSN . scrappy(at)hub(dot)org
Yahoo . yscrappy Skype: hub.org ICQ . 7615664
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFHX0fq4QvfyHIvDvMRAiKsAJ9KCM03Le0DeBHMI6IfhuX9zKajKgCdFT72
e16P8RvC9339Pot2Knf+u3Y=
=WtG8
-----END PGP SIGNATURE-----

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Alvaro Herrera Valdivia, Chile ICBM: S 39 49' 18.1", W 73 13' 56.4"

Huh ... I hadn't realized till just now that Pittsburgh is west of
Chile ... which maybe is not too good for a guy whose father spent
many years posted in South American capitals :-(

Local targeting coordinates:
http://maps.google.com/maps?q=40.4773+N+79.921+W

regards, tom lane