Re: Changes to building dynamically loadable modules

Lists: pgsql-patches
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-patches(at)postgresql(dot)org
Subject: Changes to building dynamically loadable modules
Date: 2008-04-02 19:10:16
Message-ID: 200804022110.19077.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

The attached patch implements a few changes to how shared libraries and
dynamically loadable modules are built. Foremost, it creates a solid
distinction between these two types of targets based on what had already been
implemented and duplicated in ad hoc ways before. Specifically,

- Dynamically loadable modules no longer get a soname. The numbers previously
set in the makefiles were dummy numbers anyway, and the presence of a soname
upset a few packaging tools, so it is nicer not to have one.

- The cumbersome detour taken on installation (build a libfoo.so.0.0.0 and
then override the rule to install foo.so instead) is removed.

- Lots of duplicated code simplified.

Attachment Content-Type Size
modules-without-soname.patch text/x-diff 26.7 KB

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes to building dynamically loadable modules
Date: 2008-04-02 21:01:45
Message-ID: 14339.1207170105@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> The attached patch implements a few changes to how shared libraries and
> dynamically loadable modules are built.

Looks like a good idea to me, though I've not read it in great detail
(I hate unidiffs).

regards, tom lane