| Lists: | pgsql-hackers |
|---|
| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Variable renaming in AllocSetContextCreate (will commit soon, no functional impact) |
| Date: | 2015-02-22 02:49:13 |
| Message-ID: | 1424573353.12308.240.camel@jeff-desktop |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
This is just to make the variable names in this function consistent with
the rest of the file (and less confusing). No functional impact, so I'll
commit soon unless someone objects.
Previously, this was part of the memory accounting patch, but that
hasn't made it in yet. Might as well commit the cleanup at least.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| aset_rename.diff | text/x-patch | 3.9 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact) |
| Date: | 2015-02-22 05:07:17 |
| Message-ID: | 1944.1424581637@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> This is just to make the variable names in this function consistent with
> the rest of the file (and less confusing). No functional impact, so I'll
> commit soon unless someone objects.
If I'm reading this right, this creates two different variables pointing
at the same object. That does not sound like an improvement from a
readability standpoint.
If you want to have just *one* variable but change its name and type,
I'd be ok with that.
regards, tom lane
| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact) |
| Date: | 2015-02-22 07:21:06 |
| Message-ID: | 1424589666.12308.243.camel@jeff-desktop |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sun, 2015-02-22 at 00:07 -0500, Tom Lane wrote:
> If you want to have just *one* variable but change its name and type,
> I'd be ok with that.
Thank you for taking a quick look. Committed as a simple rename from
"context" to "set".
Regards,
Jeff Davis