| Lists: | pgsql-hackers |
|---|
| From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | unused local variable |
| Date: | 2014-07-05 13:48:38 |
| Message-ID: | 1404568118.88562.YahooMailNeo@web122302.mail.ne1.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only
usage of a variable called typeStruct in plpy_spi.c, but left the
declaration and the code that sets a value for it. This is
generating a warning when I build. I would have just pushed a fix,
but I was concerned that it might have been left on purpose for
some follow-on patch. Any objections to the attached, to silence
the warning?
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| typeStruct.diff | text/x-diff | 647 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unused local variable |
| Date: | 2014-07-05 14:55:54 |
| Message-ID: | 2102.1404572154@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
> Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only
> usage of a variable called typeStruct in plpy_spi.c, but left the
> declaration and the code that sets a value for it. This is
> generating a warning when I build. I would have just pushed a fix,
> but I was concerned that it might have been left on purpose for
> some follow-on patch. Any objections to the attached, to silence
> the warning?
Huh. Odd that I did not see such a warning here. No objection to
removing the dead variable.
regards, tom lane
| From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unused local variable |
| Date: | 2014-07-05 16:11:29 |
| Message-ID: | 1404576689.83497.YahooMailNeo@web122302.mail.ne1.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
>> typeStruct in plpy_spi.c
> No objection to removing the dead variable.
Done.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company