Re: Should we improve documentation on isolation levels?

Lists: pgsql-hackers
From: AK <alkuzo(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Should we improve documentation on isolation levels?
Date: 2013-11-27 19:37:12
Message-ID: 1385581032578-5780629.post@n5.nabble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I am not sure if i am posting in the right place - correct me if I am wrong.
The following is not precise:

13.2.1. Read Committed Isolation Level

"Also note that two successive SELECT commands can see different data, even
though they are within a single transaction, if other transactions commit
changes during execution of the first SELECT."

I think it should be re-worded as follows

"Also note that two successive SELECT commands can see different data, even
though they are within a single transaction, if other transactions commit
after the first SELECT starts, and before the second SELECT starts."

The reason: there could be other DML running between these two SELECTs.

--
View this message in context: http://postgresql.1045698.n5.nabble.com/Should-we-improve-documentation-on-isolation-levels-tp5780629.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.


From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: AK <alkuzo(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should we improve documentation on isolation levels?
Date: 2013-11-27 19:46:31
Message-ID: 1385581591.20715.YahooMailNeo@web162906.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

AK <alkuzo(at)gmail(dot)com> wrote:

> The following is not precise:
>
> 13.2.1. Read Committed Isolation Level
>
> "Also note that two successive SELECT commands can see different data, even
> though they are within a single transaction, if other transactions commit
> changes during execution of the first SELECT."
>
> I think it should be re-worded as follows
>
> "Also note that two successive SELECT commands can see different data, even
> though they are within a single transaction, if other transactions commit
> after the first SELECT starts, and before the second SELECT starts."
>
> The reason: there could be other DML running between these two SELECTs.

That's a fair point.  I'll commit something to the master branch.
I don't think this rises to the level of a documentation bug that
needs to be back-patched.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: AK <alkuzo(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should we improve documentation on isolation levels?
Date: 2013-11-27 19:59:23
Message-ID: 1385582363485-5780636.post@n5.nabble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I concur - the documentation is not incorrect, it is just incomplete.

--
View this message in context: http://postgresql.1045698.n5.nabble.com/Should-we-improve-documentation-on-isolation-levels-tp5780629p5780636.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.


From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: AK <alkuzo(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should we improve documentation on isolation levels?
Date: 2013-11-27 20:40:05
Message-ID: 1385584805.91462.YahooMailNeo@web162905.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

AK <alkuzo(at)gmail(dot)com> wrote:

> the documentation is not incorrect, it is just incomplete.

Yeah, that's exactly how I saw it.  :-)

Docs changed on master only.  Thanks for the report!

--

Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company