passing diff options to pg_regress

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: passing diff options to pg_regress
Date: 2013-01-14 11:57:52
Message-ID: 1358164672.29612.10.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I sometimes find it useful to view a regression test difference using
other diff options, such as -u -w or more context. There is currently
no easy way to accomplish that.

I suggest allowing to override the diff options using an environment
variable, such as PG_REGRESS_DIFF_OPTS. The patch is very small.

Attachment Content-Type Size
pg-regress-diff-opts.patch text/x-patch 411 bytes

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: passing diff options to pg_regress
Date: 2013-01-14 12:04:00
Message-ID: 20130114120400.GA5005@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2013-01-14 06:57:52 -0500, Peter Eisentraut wrote:
> I sometimes find it useful to view a regression test difference using
> other diff options, such as -u -w or more context. There is currently
> no easy way to accomplish that.
>
> I suggest allowing to override the diff options using an environment
> variable, such as PG_REGRESS_DIFF_OPTS. The patch is very small.
>
+ERANGE

I usually do this by manually doing the diff, but thats pretty annoying.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: passing diff options to pg_regress
Date: 2013-01-15 19:51:25
Message-ID: CA+TgmoaGAeSd9OasLogtXRDNUOSUb1hjj2sorQn5N-kA2n+zYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Jan 14, 2013 at 6:57 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> I sometimes find it useful to view a regression test difference using
> other diff options, such as -u -w or more context. There is currently
> no easy way to accomplish that.
>
> I suggest allowing to override the diff options using an environment
> variable, such as PG_REGRESS_DIFF_OPTS. The patch is very small.

Great idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: passing diff options to pg_regress
Date: 2013-01-16 09:05:08
Message-ID: CAM2+6=UVKc1nnt3j_fgek4c6pv0sd0AFbpRh3sXTcscJ-r9vTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Peter,

Idea is really very good.

About the patch:
Patch looks good to me.
Applied cleanly on latest sources. make / make install / make check /
initdb everything works well.

Tested with few options and it is working well.

However, I think you need to add this in docs. Letting people know about
this environment variable to make use of that.

Thanks

On Wed, Jan 16, 2013 at 1:21 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Jan 14, 2013 at 6:57 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > I sometimes find it useful to view a regression test difference using
> > other diff options, such as -u -w or more context. There is currently
> > no easy way to accomplish that.
> >
> > I suggest allowing to override the diff options using an environment
> > variable, such as PG_REGRESS_DIFF_OPTS. The patch is very small.
>
> Great idea.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: passing diff options to pg_regress
Date: 2013-01-30 04:04:11
Message-ID: 1359518651.22194.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, 2013-01-16 at 14:35 +0530, Jeevan Chalke wrote:
> However, I think you need to add this in docs. Letting people know
> about this environment variable to make use of that.

Done and committed. Thanks.