psql tab completion for GRANT role

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: psql tab completion for GRANT role
Date: 2012-01-08 20:48:12
Message-ID: 1326055692.15293.15.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

psql tab completion currently only supports the form GRANT privilege ON
something TO someone (and the analogous REVOKE), but not the form GRANT
role TO someone. Here is a patch that attempts to implement the latter.

Attachment Content-Type Size
grant-role-tab-completion.patch text/x-patch 3.0 KB

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql tab completion for GRANT role
Date: 2012-06-14 17:38:25
Message-ID: CA+TgmoYPik3gW8J_TCR0FETXBDZz3J6XPbpu6Qi=S0U5MUmOXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> psql tab completion currently only supports the form GRANT privilege ON
> something TO someone (and the analogous REVOKE), but not the form GRANT
> role TO someone.  Here is a patch that attempts to implement the latter.

This seems to have fallen through the cracks. It doesn't apply any
more, but one general comment is that it seems undesirable to
repeatedly recapitulate the list of all privileges that exist in the
system. That's a lot of places that someone will have to find and fix
when new privileges are added.

But +1 on the general idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql tab completion for GRANT role
Date: 2012-06-19 07:16:17
Message-ID: 1340090177.26286.14.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On tor, 2012-06-14 at 13:38 -0400, Robert Haas wrote:
> On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > psql tab completion currently only supports the form GRANT privilege ON
> > something TO someone (and the analogous REVOKE), but not the form GRANT
> > role TO someone. Here is a patch that attempts to implement the latter.
>
> This seems to have fallen through the cracks.

No, it was committed in January.


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql tab completion for GRANT role
Date: 2012-06-20 01:16:21
Message-ID: CA+Tgmoa-71pzPYSA2zNKrBECXWpJ638qzqUtLc2YHY-AwOngaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jun 19, 2012 at 3:16 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On tor, 2012-06-14 at 13:38 -0400, Robert Haas wrote:
>> On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> > psql tab completion currently only supports the form GRANT privilege ON
>> > something TO someone (and the analogous REVOKE), but not the form GRANT
>> > role TO someone.  Here is a patch that attempts to implement the latter.
>>
>> This seems to have fallen through the cracks.
>
> No, it was committed in January.

Oops, I missed that. Sorry for the noise.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company