Re: BUG #5963: make -j4 check fails

Lists: pgsql-bugs
From: Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: BUG #5963: make -j4 check fails
Date: 2011-04-05 20:31:35
Message-ID: BANLkTinjVR4w5J=p0P4vPuQ_kxUW3sz4UA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

> The following bug has been logged online:
>
> Bug reference: 5963
> Logged by: Gavin Flower
> Email address: gavin(dot)flower(at)archidevsys(dot)co(dot)nz
> PostgreSQL version: 9.1alpha5
> Operating system: x86_64 Linux
> Description: make -j4 check fails
> Details:
>
> After executing
> time -j4 make
> I went to initiate the testing (note: I deleted the directory, re-extracted
> and repeated the compile for each of the following options):
>
> executing
> time make check
> works (All 126 tests passed)
>
> but executing
> time make -j4 check
> fails (I don't see any obvious problem in the log file):
> [...]
> ============== creating temporary installation ==============
>
> pg_regress: installation failed
> Examine
> /home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/log
> /install.log for the reason.
> Command was: "make" -C "../../.."
> DESTDIR="/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/re
> gress/./tmp_check/install" install >
> "/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/lo
> g/install.log" 2>&1
> make[2]: *** [check] Error 2
> make[2]: Leaving directory
> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress'
> make[1]: *** [check] Error 2
> make[1]: Leaving directory
> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test'
> make: *** [check] Error 2
>
> real 0m3.253s
> user 0m1.666s
> sys 0m1.141s

I did some bisecting, and it appears the problem was introduced in the
commit "Improved parallel make support" on November 12, 2010.


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: BUG #5963: make -j4 check fails
Date: 2011-04-25 15:03:10
Message-ID: BANLkTimwS-_tQ9-KtKOKr_jKVDetyqmvVg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Tue, Apr 5, 2011 at 4:31 PM, Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com> wrote:
>> The following bug has been logged online:
>>
>> Bug reference:      5963
>> Logged by:          Gavin Flower
>> Email address:      gavin(dot)flower(at)archidevsys(dot)co(dot)nz
>> PostgreSQL version: 9.1alpha5
>> Operating system:   x86_64 Linux
>> Description:        make -j4 check fails
>> Details:
>>
>> After executing
>>     time -j4 make
>> I went to initiate the testing (note: I deleted the directory, re-extracted
>> and repeated the compile for each of the following options):
>>
>> executing
>>    time make check
>> works (All 126 tests passed)
>>
>> but executing
>>    time make -j4 check
>> fails (I don't see any obvious problem in the log file):
>> [...]
>> ============== creating temporary installation        ==============
>>
>> pg_regress: installation failed
>> Examine
>> /home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/log
>> /install.log for the reason.
>> Command was: "make" -C "../../.."
>> DESTDIR="/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/re
>> gress/./tmp_check/install" install >
>> "/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/lo
>> g/install.log" 2>&1
>> make[2]: *** [check] Error 2
>> make[2]: Leaving directory
>> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress'
>> make[1]: *** [check] Error 2
>> make[1]: Leaving directory
>> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test'
>> make: *** [check] Error 2
>>
>> real  0m3.253s
>> user  0m1.666s
>> sys   0m1.141s
>
> I did some bisecting, and it appears the problem was introduced in the
> commit "Improved parallel make support" on November 12, 2010.

I suspect this needs a fix along the lines of commit
4502c8e1c06164adb7be526096e91e04d1844d36, which I believe fixed a
similar problem for 'make install'.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5963: make -j4 check fails
Date: 2011-08-22 16:37:43
Message-ID: 1314031063.22082.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On mån, 2011-04-25 at 11:03 -0400, Robert Haas wrote:
> >> but executing
> >> time make -j4 check
> >> fails (I don't see any obvious problem in the log file):
> >> [...]
> >> ============== creating temporary installation
> ==============
> >>
> >> pg_regress: installation failed
> >> Examine
> >> /home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/log
> >> /install.log for the reason.
> >> Command was: "make" -C "../../.."
> >>
> DESTDIR="/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/re
> >> gress/./tmp_check/install" install >
> >>
> "/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress/lo
> >> g/install.log" 2>&1
> >> make[2]: *** [check] Error 2
> >> make[2]: Leaving directory
> >>
> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test/regress'
> >> make[1]: *** [check] Error 2
> >> make[1]: Leaving directory
> >> `/home/gavin/AAA/updates/postgresql/postgresql-9.1alpha5/src/test'
> >> make: *** [check] Error 2
> >>
> >> real 0m3.253s
> >> user 0m1.666s
> >> sys 0m1.141s
> >
> > I did some bisecting, and it appears the problem was introduced in
> the
> > commit "Improved parallel make support" on November 12, 2010.
>
> I suspect this needs a fix along the lines of commit
> 4502c8e1c06164adb7be526096e91e04d1844d36, which I believe fixed a
> similar problem for 'make install'.

That commit should have fixed this problem as well.